dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart - Issue 108923003: Fix issues that caused revert of r30955:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 108923003: Fix issues that caused revert of r30955: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged with r30973. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart ('k') | dart/sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

index 7afb5d570fe2c0016b11b777b85180ceaee94562..1076afe00b48e75ddd575ea8f1e6f64656af08dd 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

@@ -84,7 +84,8 @@ String getReflectionDataParser(String classesCollector,

var optionalParameterCount = optionalParameterInfo >> 1;

var optionalParametersAreNamed = (optionalParameterInfo & 1) === 1;

var functionTypeIndex = ${readFunctionType("array", "2")};

- var isReflectable = array.length > optionalParameterCount + 3;

+ var isReflectable =''' // Break long line.

+ ''' array.length > requiredParameterCount + optionalParameterCount + 3;

if (getterStubName) {

f = tearOff(funcs, array, isStatic, name);

'''