tests for inlining between IR and AST functions

tests for inlining between IR and AST functions

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31256

[ngeoffray, 2013-12-17 12:52:33]

LGTM

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:130: if
(!compiler.irBuilder.hasIr(element) &&
Since this is for testing purposes, should you assert instead?

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:162: final
Map<Element, bool> _enforceIrElements = <Element, bool>{};
Because this is for testing: maybe do it lazily, in enforceIrRepresentation and
enforceAstRepresentation.

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1811: } else
if (cls == irRepresentationClass) {
Do it lazily?

https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...
File tests/compiler/dart2js_native/dart2js_native.status (right):

https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...
tests/compiler/dart2js_native/dart2js_native.status:12: ir_representation_test:
CompileTimeError
Please add a issue number.

[lukas, 2013-12-17 13:03:42]

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:130: if
(!compiler.irBuilder.hasIr(element) &&
On 2013/12/17 12:52:33, ngeoffray wrote:
> Since this is for testing purposes, should you assert instead?

Then the "ir_representation_test.dart" would compile in unchecked mode (it's
supposed to fail, see my last comment
https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...)

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/108333007/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1811: } else
if (cls == irRepresentationClass) {
On 2013/12/17 12:52:33, ngeoffray wrote:
> Do it lazily?

Which part exactly? Note that the code is guarded by

  if (!library.isPlatformLibrary && !library.canUseNative) return;

https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...
File tests/compiler/dart2js_native/dart2js_native.status (right):

https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...
tests/compiler/dart2js_native/dart2js_native.status:12: ir_representation_test:
CompileTimeError
On 2013/12/17 12:52:33, ngeoffray wrote:
> Please add a issue number.

There is no issue because the test is supposed to not compiler.
This is to test the @IrRepresentation(true) annotation, which is added to a
method that cannot be represented as IR.

Is there a better way to test this?

[lukas, 2013-12-18 15:56:10]

PTAL

[ngeoffray, 2013-12-19 09:49:07]

LGTM!

https://codereview.chromium.org/108333007/diff/30008/tests/compiler/dart2js_e...
File tests/compiler/dart2js_extra/dart2js_extra.status (right):

https://codereview.chromium.org/108333007/diff/30008/tests/compiler/dart2js_e...
tests/compiler/dart2js_extra/dart2js_extra.status:18: # Can't use multitest: an
import path contains '..', which is not supported.
Maybe put that as a note instead. The main comment should explain why it is OK
for this test to be a compile time error.

[lukas, 2013-12-19 11:32:48]

https://codereview.chromium.org/108333007/diff/30008/tests/compiler/dart2js_e...
File tests/compiler/dart2js_extra/dart2js_extra.status (right):

https://codereview.chromium.org/108333007/diff/30008/tests/compiler/dart2js_e...
tests/compiler/dart2js_extra/dart2js_extra.status:18: # Can't use multitest: an
import path contains '..', which is not supported.
On 2013/12/19 09:49:08, ngeoffray wrote:
> Maybe put that as a note instead. The main comment should explain why it is OK
> for this test to be a compile time error.

Done.

[lukas, 2013-12-19 11:33:17]

Committed patchset #3 manually as r31256 (presubmit successful).