tests for inlining between IR and AST functions

sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 const VERBOSE_OPTIMIZER_HINTS = false;
 
 class JavaScriptItemCompilationContext extends ItemCompilationContext {
   final Set<HInstruction> boundsChecked = new Set<HInstruction>();
@@ skipping 89 matching lines @@
   Element objectEquals;
 
   ClassElement typeLiteralClass;
   ClassElement mapLiteralClass;
   ClassElement constMapLiteralClass;
   ClassElement typeVariableClass;
 
   ClassElement noSideEffectsClass;
   ClassElement noThrowsClass;
   ClassElement noInlineClass;
+  ClassElement irRepresentationClass;
 
   Element getInterceptorMethod;
   Element interceptedNames;
 
   /**
    * This element is a top-level variable (in generated output) that the
    * compiler initializes to a datastructure used to map from a Type to the
    * interceptor.  See declaration of `mapTypeToInterceptor` in
    * `interceptors.dart`.
    */
@@ skipping 31 matching lines @@
    * libraries.
    */
   ClassElement jsIndexingBehaviorInterface;
 
   /**
    * A collection of selectors that must have a one shot interceptor
    * generated.
    */
   final Map<String, Selector> oneShotInterceptors;
 
+  final Map<Element, bool> _enforceIrElements = <Element, bool>{};

[ngeoffray, 2013/12/17 12:52:33]

Because this is for testing: maybe do it lazily, in enforceIrRepresentation and
enforceAstRepresentation.

+
+  bool enforceIrRepresentation(Element element) {
+    // Testing [:== true:]is required because the lookup might return [:null:].
+    return _enforceIrElements[element] == true;
+  }
+
+  bool enforceAstRepresentation(Element element) {
+    // Testing [:== false:]is required because the lookup might return [:null:].
+    return _enforceIrElements[element] == false;
+  }
+
   /**
    * The members of instantiated interceptor classes: maps a member name to the
    * list of members that have that name. This map is used by the codegen to
    * know whether a send must be intercepted or not.
    */
   final Map<String, Set<Element>> interceptedElements;
   // TODO(sra): Not all methods in the Set always require an interceptor.  A
   // method may be mixed into a true interceptor *and* a plain class. For the
   // method to work on the interceptor class it needs to use the explicit
   // receiver.  This constrains the call on a known plain receiver to pass the
@@ skipping 343 matching lines @@
     indexablePrimitiveType = new TypeMask.nonNullSubtype(jsIndexableClass);
     readableArrayType = new TypeMask.nonNullSubclass(jsArrayClass);
     mutableArrayType = new TypeMask.nonNullSubclass(jsMutableArrayClass);
     fixedArrayType = new TypeMask.nonNullExact(jsFixedArrayClass);
     extendableArrayType = new TypeMask.nonNullExact(jsExtendableArrayClass);
     nonNullType = compiler.typesTask.dynamicType.nonNullable();
 
     noSideEffectsClass = compiler.findHelper('NoSideEffects');
     noThrowsClass = compiler.findHelper('NoThrows');
     noInlineClass = compiler.findHelper('NoInline');
+    irRepresentationClass = compiler.findHelper('IrRepresentation');
   }
 
   void validateInterceptorImplementsAllObjectMethods(
       ClassElement interceptorClass) {
     if (interceptorClass == null) return;
     interceptorClass.ensureResolved(compiler);
     compiler.objectClass.forEachMember((_, Element member) {
       if (member.isGenerativeConstructor()) return;
       Element interceptorMember = interceptorClass.lookupMember(member.name);
       // Interceptors must override all Object methods due to calling convention
@@ skipping 1253 matching lines @@
         if (VERBOSE_OPTIMIZER_HINTS) {
           compiler.reportHere(element, "Cannot throw");
         }
         compiler.world.registerCannotThrow(element);
       } else if (cls == noSideEffectsClass) {
         hasNoSideEffects = true;
         if (VERBOSE_OPTIMIZER_HINTS) {
           compiler.reportHere(element, "Has no side effects");
         }
         compiler.world.registerSideEffectsFree(element);
+      } else if (cls == irRepresentationClass) {

[ngeoffray, 2013/12/17 12:52:33]

Do it lazily?

[lukas, 2013/12/17 13:03:43]

Which part exactly? Note that the code is guarded by

  if (!library.isPlatformLibrary && !library.canUseNative) return;

+        ConstructedConstant classConstant = value;
+        BoolConstant constant = classConstant.fields[0];
+        _enforceIrElements[element] = constant.value;
       }
     }
     if (hasNoThrows && !hasNoInline) {
       compiler.internalErrorOnElement(
           element, "@NoThrows() should always be combined with @NoInline");
     }
     if (hasNoSideEffects && !hasNoInline) {
       compiler.internalErrorOnElement(
           element, "@NoSideEffects() should always be combined with @NoInline");
     }
@@ skipping 55 matching lines @@
     copy(constant.values);
     copy(constant.protoValue);
     copy(constant);
   }
 
   void visitConstructed(ConstructedConstant constant) {
     copy(constant.fields);
     copy(constant);
   }
 }