tests for inlining between IR and AST functions

sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_builder;
 
 import 'ir_nodes.dart';
 import '../elements/elements.dart';
 import '../elements/modelx.dart' show FunctionElementX;
 import '../dart2jslib.dart';
@@ skipping 65 matching lines @@
               LibraryElement library = element.declaration.getLibrary();
               IrConstantPool constantPool = IrConstantPool.forLibrary(library);
               List<int> data = irNode.pickle(constantPool);
               irNode = new Unpickler(compiler, constantPool).unpickle(data);
               return true;
             });
             nodes[element] = irNode;
             unlinkTreeAndToken(element);
           }
         }
+        ensureIr(element);
       });
     });
   }
 
   bool irEnabled() {
     // TODO(lry): support checked-mode checks.
     if (compiler.enableTypeAssertions ||
         compiler.backend is !JavaScriptBackend ||
         compiler.enableConcreteTypeInference) {
       return false;
@@ skipping 11 matching lines @@
     if (signature.parameterCount > 0) return false;
 
     // TODO(lry): support intercepted methods. Then the dependency on
     // JavaScriptBackend will go away.
     JavaScriptBackend backend = compiler.backend;
     if (backend.isInterceptedMethod(element)) return false;
 
     // TODO(lry): support native functions (also in [visitReturn]).
     if (function.isNative()) return false;
 
+    // Methods annotated @IrRepresentation(false).
+    if (backend.enforceAstRepresentation(function)) return false;
+
     return true;
   }
 
+  /**
+   * If no IR was built for [element], ensure it is not annotated
+   * @IrRepresentation(true).
+   */
+  bool ensureIr(Element element) {
+    // Ensure that the method is not annotated
+    if (!compiler.irBuilder.hasIr(element) &&

[ngeoffray, 2013/12/17 12:52:33]

Since this is for testing purposes, should you assert instead?

[lukas, 2013/12/17 13:03:43]

Then the "ir_representation_test.dart" would compile in unchecked mode (it's
supposed to fail, see my last comment
https://codereview.chromium.org/108333007/diff/1/tests/compiler/dart2js_nativ...)

+        compiler.backend.enforceIrRepresentation(element))
+      compiler.internalError("coult not build IR", element: element);
+  }
+
   void unlinkTreeAndToken(element) {
     // Ensure the function signature has been computed (requires the AST).
     assert(element is !FunctionElementX || element.functionSignature != null);
     bool isCheckedMode = false;
     assert((isCheckedMode = true));
     if (isCheckedMode) {
       element.beginToken.next = null;
       element.cachedNode = null;
     }
   }
@@ skipping 233 matching lines @@
 
   void exitBlock() {
     blockBuilders.removeLast();
   }
 }
 
 class BlockBuilder {
   List<IrNode> statements = <IrNode>[];
   bool hasReturn = false;
 }