Issue 1082943003: Support PhantomJS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1082943003: Support PhantomJS. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -15 lines)			Patch
M	.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	CHANGELOG.md	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	README.md	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/src/backend/test_platform.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
A	lib/src/runner/browser/phantom_js.dart	View	1 2	1 chunk	+87 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A +	test/runner/browser/phantom_js_test.dart	View		6 chunks	+17 lines, -13 lines	0 comments	Download
M	test/runner/browser/runner_test.dart	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	test/runner/runner_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

nweiz

5 years, 8 months ago (2015-04-14 01:17:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
525e4b30ef3105d7fd1d45540803c07bae3fd6a6 (presubmit successful).