Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: test/runner/browser/phantom_js_test.dart

Issue 1082943003: Support PhantomJS. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | test/runner/browser/runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/phantom_js_test.dart
diff --git a/test/runner/browser/firefox_test.dart b/test/runner/browser/phantom_js_test.dart
similarity index 80%
copy from test/runner/browser/firefox_test.dart
copy to test/runner/browser/phantom_js_test.dart
index 6453f0dd53c470db1f0b20a94bbd0b6b8d5600d5..09a5c6b60e93b0c20c16378c6ba93c66cbc00a3f 100644
--- a/test/runner/browser/firefox_test.dart
+++ b/test/runner/browser/phantom_js_test.dart
@@ -8,7 +8,7 @@ import 'dart:async';
import 'dart:io';
import 'package:test/test.dart';
-import 'package:test/src/runner/browser/firefox.dart';
+import 'package:test/src/runner/browser/phantom_js.dart';
import 'package:test/src/util/io.dart';
import 'package:shelf/shelf.dart' as shelf;
import 'package:shelf/shelf_io.dart' as shelf_io;
@@ -67,19 +67,20 @@ void main() {
webSockets = null;
});
- test("starts Firefox with the given URL", () {
+ test("starts PhantomJs with the given URL", () {
javaScript = '''
var webSocket = new WebSocket(window.location.href.replace("http://", "ws://"));
webSocket.addEventListener("open", function() {
webSocket.send("loaded!");
});
''';
- var firefox = new Firefox(baseUrlForAddress(server.address, server.port));
+ var phantomJS = new PhantomJS(
+ baseUrlForAddress(server.address, server.port));
return webSockets.first.then((webSocket) {
return webSocket.first.then(
(message) => expect(message, equals("loaded!")));
- }).whenComplete(firefox.close);
+ }).whenComplete(phantomJS.close);
});
test("doesn't preserve state across runs", () {
@@ -91,16 +92,17 @@ webSocket.addEventListener("open", function() {
webSocket.send("done");
});
''';
- var firefox = new Firefox(baseUrlForAddress(server.address, server.port));
+ var phantomJS = new PhantomJS(
+ baseUrlForAddress(server.address, server.port));
var first = true;
webSockets.listen(expectAsync((webSocket) {
if (first) {
// The first request will set local storage data. We can't kill the
- // old firefox and start a new one until we're sure that that has
+ // old PhantomJS and start a new one until we're sure that that has
// finished.
webSocket.first.then((_) {
- firefox.close();
+ phantomJS.close();
javaScript = '''
var webSocket = new WebSocket(window.location.href.replace("http://", "ws://"));
@@ -108,7 +110,8 @@ webSocket.addEventListener("open", function() {
webSocket.send(localStorage.getItem("data"));
});
''';
- firefox = new Firefox(baseUrlForAddress(server.address, server.port));
+ phantomJS = new PhantomJS(
+ baseUrlForAddress(server.address, server.port));
first = false;
});
} else {
@@ -117,7 +120,7 @@ webSocket.addEventListener("open", function() {
expect(
webSocket.first
.then((message) => expect(message, equals('null')))
- .whenComplete(firefox.close),
+ .whenComplete(phantomJS.close),
completes);
}
}, count: 2));
@@ -127,14 +130,15 @@ webSocket.addEventListener("open", function() {
test("a process can be killed synchronously after it's started", () {
return shelf_io.serve(expectAsync((_) {}, count: 0), 'localhost', 0)
.then((server) {
- var firefox = new Firefox(baseUrlForAddress(server.address, server.port));
- return firefox.close().whenComplete(server.close);
+ var phantomJS = new PhantomJS(
+ baseUrlForAddress(server.address, server.port));
+ return phantomJS.close().whenComplete(server.close);
});
});
test("reports an error in onExit", () {
- var firefox = new Firefox("http://dart-lang.org",
+ var phantomJS = new PhantomJS("http://dart-lang.org",
executable: "_does_not_exist");
- expect(firefox.onExit, throwsA(new isInstanceOf<ProcessException>()));
+ expect(phantomJS.onExit, throwsA(new isInstanceOf<ProcessException>()));
});
}
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | test/runner/browser/runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698