Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: test/runner/browser/runner_test.dart

Issue 1082943003: Support PhantomJS. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/phantom_js_test.dart ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/runner_test.dart
diff --git a/test/runner/browser/runner_test.dart b/test/runner/browser/runner_test.dart
index e2c4072f2aa8b0c3fb62ecb20291ca834e98fc2c..80f9774eefc82df5a18511c07a3ff6138c2514f3 100644
--- a/test/runner/browser/runner_test.dart
+++ b/test/runner/browser/runner_test.dart
@@ -126,6 +126,12 @@ void main() {
expect(result.exitCode, equals(0));
});
+ test("on PhantomJS", () {
+ new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_success);
+ var result = _runUnittest(["-p", "phantomjs", "test.dart"]);
+ expect(result.exitCode, equals(0));
+ });
+
test("on Firefox", () {
new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_success);
var result = _runUnittest(["-p", "firefox", "test.dart"]);
@@ -175,6 +181,12 @@ void main() {
expect(result.exitCode, equals(1));
});
+ test("on PhantomJS", () {
+ new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_failure);
+ var result = _runUnittest(["-p", "phantomjs", "test.dart"]);
+ expect(result.exitCode, equals(1));
+ });
+
test("on Firefox", () {
new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_failure);
var result = _runUnittest(["-p", "firefox", "test.dart"]);
« no previous file with comments | « test/runner/browser/phantom_js_test.dart ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698