Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1072043002: dart2js: retain constants that are used as annotations in constructors and setters. (Closed)

Created:
5 years, 8 months ago by floitsch
Modified:
5 years, 8 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: retain constants that are used as annotations in constructors and setters. BUG= http://dartbug.com/23128 R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=45064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/mirrors/parameter_annotation_mirror_test.dart View 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 8 months ago (2015-04-09 15:23:38 UTC) #2
herhut
lgtm
5 years, 8 months ago (2015-04-10 08:19:23 UTC) #3
floitsch
5 years, 8 months ago (2015-04-10 13:10:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698