Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tests/lib/mirrors/parameter_annotation_mirror_test.dart

Issue 1072043002: dart2js: retain constants that are used as annotations in constructors and setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/parameter_annotation_mirror_test.dart
diff --git a/tests/lib/mirrors/parameter_annotation_mirror_test.dart b/tests/lib/mirrors/parameter_annotation_mirror_test.dart
index 1b2a451c992f3f8919d762533a23b5bb51617a45..be104e4b006f0c6975e1c89b197f21d46fc79669 100644
--- a/tests/lib/mirrors/parameter_annotation_mirror_test.dart
+++ b/tests/lib/mirrors/parameter_annotation_mirror_test.dart
@@ -13,6 +13,11 @@ class ParameterAnnotation {
}
class Foo {
+ Foo(@ParameterAnnotation("vogel") p) {}
+ Foo.named(@ParameterAnnotation("hamster") p) {}
+ Foo.named2(@ParameterAnnotation("hamster") p,
+ @ParameterAnnotation("wurm") p2) {}
+
f1(@ParameterAnnotation("hest") p) {}
f2(@ParameterAnnotation("hest") @ParameterAnnotation("fisk") p) {}
f3(a, @ParameterAnnotation("fugl") p) {}
@@ -22,6 +27,8 @@ class Foo {
[@ParameterAnnotation("hval") p]) {}
f6({@ParameterAnnotation("fisk") z,
@ParameterAnnotation("hval") p}) {}
+
+ set s1(@ParameterAnnotation("cheval") p) {}
}
expectAnnotations(Type type, Symbol method, int parameterIndex,
@@ -39,6 +46,11 @@ expectAnnotations(Type type, Symbol method, int parameterIndex,
}
main() {
+ expectAnnotations(Foo, #Foo, 0, ["vogel"]);
+ expectAnnotations(Foo, #Foo.named, 0, ["hamster"]);
+ expectAnnotations(Foo, #Foo.named2, 0, ["hamster"]);
+ expectAnnotations(Foo, #Foo.named2, 1, ["wurm"]);
+
expectAnnotations(Foo, #f1, 0, ["hest"]);
expectAnnotations(Foo, #f2, 0, ["hest", "fisk"]);
expectAnnotations(Foo, #f3, 0, []);
@@ -49,4 +61,6 @@ main() {
expectAnnotations(Foo, #f5, 1, ["hval"]);
expectAnnotations(Foo, #f6, 0, ["fisk"]);
expectAnnotations(Foo, #f6, 1, ["hval"]);
+
+ expectAnnotations(Foo, const Symbol('s1='), 0, ["cheval"]);
}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698