Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: tests/lib/mirrors/parameter_annotation_mirror_test.dart

Issue 1072043002: dart2js: retain constants that are used as annotations in constructors and setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 @MirrorsUsed(targets: "Foo") 5 @MirrorsUsed(targets: "Foo")
6 import "dart:mirrors"; 6 import "dart:mirrors";
7 7
8 import 'package:expect/expect.dart'; 8 import 'package:expect/expect.dart';
9 9
10 class ParameterAnnotation { 10 class ParameterAnnotation {
11 final String value; 11 final String value;
12 const ParameterAnnotation(this.value); 12 const ParameterAnnotation(this.value);
13 } 13 }
14 14
15 class Foo { 15 class Foo {
16 Foo(@ParameterAnnotation("vogel") p) {}
17 Foo.named(@ParameterAnnotation("hamster") p) {}
18 Foo.named2(@ParameterAnnotation("hamster") p,
19 @ParameterAnnotation("wurm") p2) {}
20
16 f1(@ParameterAnnotation("hest") p) {} 21 f1(@ParameterAnnotation("hest") p) {}
17 f2(@ParameterAnnotation("hest") @ParameterAnnotation("fisk") p) {} 22 f2(@ParameterAnnotation("hest") @ParameterAnnotation("fisk") p) {}
18 f3(a, @ParameterAnnotation("fugl") p) {} 23 f3(a, @ParameterAnnotation("fugl") p) {}
19 f4(@ParameterAnnotation("fisk") a, 24 f4(@ParameterAnnotation("fisk") a,
20 {@ParameterAnnotation("hval") p}) {} 25 {@ParameterAnnotation("hval") p}) {}
21 f5(@ParameterAnnotation("fisk") a, 26 f5(@ParameterAnnotation("fisk") a,
22 [@ParameterAnnotation("hval") p]) {} 27 [@ParameterAnnotation("hval") p]) {}
23 f6({@ParameterAnnotation("fisk") z, 28 f6({@ParameterAnnotation("fisk") z,
24 @ParameterAnnotation("hval") p}) {} 29 @ParameterAnnotation("hval") p}) {}
30
31 set s1(@ParameterAnnotation("cheval") p) {}
25 } 32 }
26 33
27 expectAnnotations(Type type, Symbol method, int parameterIndex, 34 expectAnnotations(Type type, Symbol method, int parameterIndex,
28 List<String> expectedValues) { 35 List<String> expectedValues) {
29 MethodMirror mirror = reflectClass(type).declarations[method]; 36 MethodMirror mirror = reflectClass(type).declarations[method];
30 ParameterMirror parameter = mirror.parameters[parameterIndex]; 37 ParameterMirror parameter = mirror.parameters[parameterIndex];
31 List<InstanceMirror> annotations = parameter.metadata; 38 List<InstanceMirror> annotations = parameter.metadata;
32 Expect.equals(annotations.length, expectedValues.length, 39 Expect.equals(annotations.length, expectedValues.length,
33 "wrong number of parameter annotations"); 40 "wrong number of parameter annotations");
34 for (int i = 0; i < annotations.length; i++) { 41 for (int i = 0; i < annotations.length; i++) {
35 Expect.equals(expectedValues[i], annotations[i].reflectee.value, 42 Expect.equals(expectedValues[i], annotations[i].reflectee.value,
36 "annotation #$i of parameter #$parameterIndex " 43 "annotation #$i of parameter #$parameterIndex "
37 "of $type.$method."); 44 "of $type.$method.");
38 } 45 }
39 } 46 }
40 47
41 main() { 48 main() {
49 expectAnnotations(Foo, #Foo, 0, ["vogel"]);
50 expectAnnotations(Foo, #Foo.named, 0, ["hamster"]);
51 expectAnnotations(Foo, #Foo.named2, 0, ["hamster"]);
52 expectAnnotations(Foo, #Foo.named2, 1, ["wurm"]);
53
42 expectAnnotations(Foo, #f1, 0, ["hest"]); 54 expectAnnotations(Foo, #f1, 0, ["hest"]);
43 expectAnnotations(Foo, #f2, 0, ["hest", "fisk"]); 55 expectAnnotations(Foo, #f2, 0, ["hest", "fisk"]);
44 expectAnnotations(Foo, #f3, 0, []); 56 expectAnnotations(Foo, #f3, 0, []);
45 expectAnnotations(Foo, #f3, 1, ["fugl"]); 57 expectAnnotations(Foo, #f3, 1, ["fugl"]);
46 expectAnnotations(Foo, #f4, 0, ["fisk"]); 58 expectAnnotations(Foo, #f4, 0, ["fisk"]);
47 expectAnnotations(Foo, #f4, 1, ["hval"]); 59 expectAnnotations(Foo, #f4, 1, ["hval"]);
48 expectAnnotations(Foo, #f5, 0, ["fisk"]); 60 expectAnnotations(Foo, #f5, 0, ["fisk"]);
49 expectAnnotations(Foo, #f5, 1, ["hval"]); 61 expectAnnotations(Foo, #f5, 1, ["hval"]);
50 expectAnnotations(Foo, #f6, 0, ["fisk"]); 62 expectAnnotations(Foo, #f6, 0, ["fisk"]);
51 expectAnnotations(Foo, #f6, 1, ["hval"]); 63 expectAnnotations(Foo, #f6, 1, ["hval"]);
64
65 expectAnnotations(Foo, const Symbol('s1='), 0, ["cheval"]);
52 } 66 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698