Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 1046193002: GenerateHintsTask - partial implementation. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

GenerateHintsTask - partial implementation. 1. We need to ensure somehow that TypeProvider's types hierarchies are finished. 2. We need aggregating tasks to compute used imported / local elements. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +89 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/mock_sdk.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +84 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-03-31 15:59:14 UTC) #1
Brian Wilkerson
LGTM > 1. We need to ensure somehow that TypeProvider's types hierarchies are finished. Is ...
5 years, 8 months ago (2015-03-31 18:06:06 UTC) #2
scheglov
5 years, 8 months ago (2015-03-31 18:14:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698