GenerateHintsTask - partial implementation.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import "dart:math" as math;
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ skipping 4397 matching lines @@
     // dead code analysis
     unit.accept(new DeadCodeVerifier(errorReporter));
     unit.accept(_usedElementsVisitor);
     // dart2js analysis
     if (_enableDart2JSHints) {
       unit.accept(new Dart2JSVerifier(errorReporter));
     }
     // Dart best practices
     unit.accept(
         new BestPracticesVerifier(errorReporter, _context.typeProvider));
-    unit.accept(new OverrideVerifier(_manager, errorReporter));
+    unit.accept(new OverrideVerifier(errorReporter, _manager));
     // Find to-do comments
     new ToDoFinder(errorReporter).findIn(unit);
     // pub analysis
     // TODO(danrubel/jwren) Commented out until bugs in the pub verifier are
     // fixed
     //    unit.accept(new PubVerifier(context, errorReporter));
   }
 }
 
 /**
@@ skipping 5058 matching lines @@
     return newNames;
   }
 }
 
 /**
  * Instances of the class `OverrideVerifier` visit all of the declarations in a compilation
  * unit to verify that if they have an override annotation it is being used correctly.
  */
 class OverrideVerifier extends RecursiveAstVisitor<Object> {
   /**
+   * The error reporter used to report errors.
+   */
+  final ErrorReporter _errorReporter;
+
+  /**
    * The inheritance manager used to find overridden methods.
    */
   final InheritanceManager _manager;
 
   /**
-   * The error reporter used to report errors.
-   */
-  final ErrorReporter _errorReporter;
-
-  /**
    * Initialize a newly created verifier to look for inappropriate uses of the override annotation.
    *
+   * @param errorReporter the error reporter used to report errors
    * @param manager the inheritance manager used to find overridden methods
-   * @param errorReporter the error reporter used to report errors
    */
-  OverrideVerifier(this._manager, this._errorReporter);
+  OverrideVerifier(this._errorReporter, this._manager);
 
   @override
   Object visitMethodDeclaration(MethodDeclaration node) {
     ExecutableElement element = node.element;
     if (_isOverride(element)) {
       if (_getOverriddenMember(element) == null) {
         if (element is MethodElement) {
           _errorReporter.reportErrorForNode(
               HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD, node.name);
         } else if (element is PropertyAccessorElement) {
@@ skipping 5882 matching lines @@
   }
 
   bool isCatchException(LocalVariableElement element) {
     return catchExceptionElements.contains(element);
   }
 
   bool isCatchStackTrace(LocalVariableElement element) {
     return catchStackTraceElements.contains(element);
   }
 }