Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1046193002: GenerateHintsTask - partial implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index d4c1034df62c157e47c908f9fac5c552d6f96750..7fae44883f5dfba1b50bf952eb5290687297466d 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -4415,7 +4415,7 @@ class HintGenerator {
// Dart best practices
unit.accept(
new BestPracticesVerifier(errorReporter, _context.typeProvider));
- unit.accept(new OverrideVerifier(_manager, errorReporter));
+ unit.accept(new OverrideVerifier(errorReporter, _manager));
// Find to-do comments
new ToDoFinder(errorReporter).findIn(unit);
// pub analysis
@@ -9494,22 +9494,22 @@ class NamespaceBuilder {
*/
class OverrideVerifier extends RecursiveAstVisitor<Object> {
/**
- * The inheritance manager used to find overridden methods.
+ * The error reporter used to report errors.
*/
- final InheritanceManager _manager;
+ final ErrorReporter _errorReporter;
/**
- * The error reporter used to report errors.
+ * The inheritance manager used to find overridden methods.
*/
- final ErrorReporter _errorReporter;
+ final InheritanceManager _manager;
/**
* Initialize a newly created verifier to look for inappropriate uses of the override annotation.
*
- * @param manager the inheritance manager used to find overridden methods
* @param errorReporter the error reporter used to report errors
+ * @param manager the inheritance manager used to find overridden methods
*/
- OverrideVerifier(this._manager, this._errorReporter);
+ OverrideVerifier(this._errorReporter, this._manager);
@override
Object visitMethodDeclaration(MethodDeclaration node) {
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698