Parse more properties of native code fragments.

Parse more properties of native code fragments.
';' is now a separator rather than a terminator.

Add properties for:
- throwing behaviour
- allocation (fresh unaliased object)
- gvn

These are currently unused.
I have a separate CL in preparation with a better throwing behaviour

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44947

[sra1, 2015-04-06 18:36:20]

sra@google.com changed reviewers:
+ floitsch@google.com

[sra1, 2015-04-06 20:14:52]

Patchset #1 (id:1) has been deleted

[sra1, 2015-04-06 20:15:04]

Patchset #1 (id:20001) has been deleted

[floitsch, 2015-04-07 15:35:16]

LGTM.

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:24: static const NativeThrowBehavior
MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS =
ONLY_THROWS_IF_FIRST_ARGUMENT_IS_NULL ?

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:147: ///    inspection as an
orthongonal attribute?
orthogonal

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:164: /// [validTags] can be used to
restric
unfinished sentence.

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:303: const map = const<String,
bool>{'true': true, 'false': false};
I'm not a fan of the map...
if (newString != "true" && newString != "false") {
  listener.internalError(spannable,
      "Unknown 'new' specification: '$newString'");
}
isAllocation = (newString == 'true');

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:313: const map = const<String,
bool>{'true': true, 'false': false};
ditto.

https://codereview.chromium.org/1034263002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/1034263002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_spec_string_test.dart:236:
testWithSideEffects('returns: A| B |C ;', returns: ['A', 'B', 'C'], creates:
[]);
long line.

[sra1, 2015-04-07 17:59:47]

PTAL

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:24: static const NativeThrowBehavior
MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS =
On 2015/04/07 15:35:16, floitsch wrote:
> ONLY_THROWS_IF_FIRST_ARGUMENT_IS_NULL ?

I'd like to keep MUST/MAY/NEVER.
This will be replaced with something better anyway.

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:147: ///    inspection as an
orthongonal attribute?
On 2015/04/07 15:35:16, floitsch wrote:
> orthogonal

Thanks!

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:164: /// [validTags] can be used to
restric
On 2015/04/07 15:35:16, floitsch wrote:
> unfinished sentence.

Done.

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:303: const map = const<String,
bool>{'true': true, 'false': false};
On 2015/04/07 15:35:16, floitsch wrote:
> I'm not a fan of the map...
> if (newString != "true" && newString != "false") {
>   listener.internalError(spannable,
>       "Unknown 'new' specification: '$newString'");
> }
> isAllocation = (newString == 'true');

I have moved this to a helper.

https://codereview.chromium.org/1034263002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:313: const map = const<String,
bool>{'true': true, 'false': false};
On 2015/04/07 15:35:16, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/1034263002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/1034263002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_spec_string_test.dart:236:
testWithSideEffects('returns: A| B |C ;', returns: ['A', 'B', 'C'], creates:
[]);
On 2015/04/07 15:35:16, floitsch wrote:
> long line.

Done.

[sra1, 2015-04-07 20:53:46]

Committed patchset #3 (id:80001) manually as 44947 (presubmit successful).

[herhut, 2015-04-08 07:43:33]

herhut@google.com changed reviewers:
+ herhut@google.com

[herhut, 2015-04-08 07:43:34]

DBC

https://codereview.chromium.org/1034263002/diff/80001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/1034263002/diff/80001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:154: ///    (new) object that cannot
be unaliased with existing objects.
Did you mean aliased here?

[floitsch, 2015-04-08 08:05:49]

LGTM.