Parse more properties of native code fragments.

tests/compiler/dart2js/js_spec_string_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Unit test of the [NativeBehavior.processSpecString] method.
 
 import 'package:expect/expect.dart';
 import 'package:compiler/src/native/native.dart';
 import 'package:compiler/src/dart2jslib.dart'
     show DiagnosticListener;
@@ skipping 10 matching lines @@
     throw "error";
   }
 
   noSuchMethod(_) => null;
 }
 
 void test(String specString,
           {List returns,
            List creates,
            SideEffects expectedSideEffects,
+           NativeThrowBehavior expectedThrows,
+           bool expectedNew,
+           bool expectedGvn,
            bool expectError: false}) {
   List actualReturns = [];
   List actualCreates = [];
   SideEffects actualSideEffects;
+  NativeThrowBehavior actualThrows;
+  bool actualNew;
+  bool actualGvn;
   Listener listener = new Listener();
   try {
     NativeBehavior.processSpecString(
         listener,
         null,
         specString,
         setSideEffects: (effects) { actualSideEffects = effects; },
+        setThrows: (b) { actualThrows = b; },
+        setIsAllocation: (b) { actualNew = b; },
+        setUseGvn: (b) { actualGvn = b; },
         resolveType: (t) => t,
         typesReturned: actualReturns, typesInstantiated: actualCreates,
         objectType: OBJECT, nullType: NULL);
   } catch (e) {
     Expect.isTrue(expectError);
     Expect.isNotNull(listener.errorMessage, 'Internal error expected.');
     return;
   }
   Expect.isNull(listener.errorMessage, 'Unexpected internal error.');
-  Expect.listEquals(returns, actualReturns, 'Unexpected returns.');
-  Expect.listEquals(creates, actualCreates, 'Unexpected creates.');
+  if (returns != null) {
+    Expect.listEquals(returns, actualReturns, 'Unexpected returns.');
+  }
+  if (creates != null) {
+    Expect.listEquals(creates, actualCreates, 'Unexpected creates.');
+  }
   Expect.equals(expectedSideEffects, actualSideEffects);
+  Expect.equals(expectedThrows, actualThrows);
+  Expect.equals(expectedNew, actualNew);
+  Expect.equals(expectedGvn, actualGvn);
 }
 
 void testWithSideEffects(String specString,
                           {List returns,
                            List creates,
                            bool expectError: false}) {
 
   void sideEffectsTest(String newSpecString, SideEffects expectedSideEffects,
                        {bool sideEffectsExpectError}) {
     test(newSpecString,
@@ skipping 146 matching lines @@
   test(' returns:A|B|C;   creates:A;  ',
       returns: ['A', 'B', 'C'], creates: ['A']);
 
   testWithSideEffects('returns:void;', returns: [], creates: []);
   testWithSideEffects('returns:void;', returns: [], creates: []);
   testWithSideEffects('returns:;', returns: [OBJECT, NULL], creates: []);
   testWithSideEffects('returns:var;', returns: [OBJECT, NULL], creates: []);
   testWithSideEffects('returns:A;', returns: ['A'], creates: []);
   testWithSideEffects('returns:A|B;', returns: ['A', 'B'], creates: []);
   testWithSideEffects('returns:A|B|C;', returns: ['A', 'B', 'C'], creates: []);
+  testWithSideEffects('returns: A| B |C ;', returns: ['A', 'B', 'C'], creates: []);

[floitsch, 2015/04/07 15:35:16]

long line.

[sra1, 2015/04/07 17:59:47]

Done.

 
   testWithSideEffects('creates:void;', expectError: true);
   testWithSideEffects('creates:;', expectError: true);
   testWithSideEffects('creates:var;', expectError: true);
   testWithSideEffects('creates:A;', returns: [], creates: ['A']);
   testWithSideEffects('creates:A|B;', returns: [], creates: ['A', 'B']);
   testWithSideEffects('creates:A|B|C;', returns: [], creates: ['A', 'B', 'C']);
 
   testWithSideEffects('returns:void;creates:A;', returns: [], creates: ['A']);
   testWithSideEffects('returns:;creates:A|B;',
       returns: [OBJECT, NULL], creates: ['A', 'B']);
   testWithSideEffects('returns:var;creates:A|B|C;',
       returns: [OBJECT, NULL], creates: ['A', 'B', 'C']);
   testWithSideEffects('returns:A; creates:A|B|C; ',
       returns: ['A'], creates: ['A', 'B', 'C']);
   testWithSideEffects(' returns:A|B;  creates:A|C;',
       returns: ['A', 'B'], creates: ['A', 'C']);
   testWithSideEffects(' returns:A|B|C;   creates:A;  ',
       returns: ['A', 'B', 'C'], creates: ['A']);
+
+  test('throws:must', expectedThrows: NativeThrowBehavior.MUST);
+  test('throws:may', expectedThrows: NativeThrowBehavior.MAY);
+  test('throws:never', expectedThrows: NativeThrowBehavior.NEVER);
+  test('throws:null(1)',
+      expectedThrows:
+          NativeThrowBehavior.MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS);
+
+  test('new:true', expectedNew: true);
+  test('new:false', expectedNew: false);
+  test('returns:A;new:true', returns: ['A'], expectedNew: true);
+  test(' new : true ;  returns:A;', returns: ['A'], expectedNew: true);
+  test('new:true;returns:A;new:true', expectError: true);
+
+  test('gvn:true', expectedGvn: true);
+  test('gvn:false', expectedGvn: false);
+  test('returns:A;gvn:true', returns: ['A'], expectedGvn: true);
+  test(' gvn : true ;  returns:A;', returns: ['A'], expectedGvn: true);
+  test('gvn:true;returns:A;gvn:true', expectError: true);
+
+  test('gvn: true; new: true', expectError: true);
+  test('gvn: true; new: false', expectedGvn: true, expectedNew: false);
+  test('gvn: false; new: true', expectedGvn: false, expectedNew: true);
+  test('gvn: false; new: false', expectedGvn: false, expectedNew: false);
 }