Parse more properties of native code fragments.

pkg/compiler/lib/src/native/behavior.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of native;
 
 /// This class is a temporary work-around until we get a more powerful DartType.
 class SpecialType {
   final String name;
   const SpecialType._(this.name);
 
   /// The type Object, but no subtypes:
   static const JsObject = const SpecialType._('=Object');
 
   int get hashCode => name.hashCode;
 }
 
+/// Description of the exception behaviour of native code.
+///
+/// TODO(sra): Replace with something that better supports specialization on
+/// first argument properties.
+class NativeThrowBehavior {
+  static const NativeThrowBehavior NEVER = const NativeThrowBehavior._(0);
+  static const NativeThrowBehavior MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS =

[floitsch, 2015/04/07 15:35:16]

ONLY_THROWS_IF_FIRST_ARGUMENT_IS_NULL ?

[sra1, 2015/04/07 17:59:47]

I'd like to keep MUST/MAY/NEVER.
This will be replaced with something better anyway.

+      const NativeThrowBehavior._(1);
+  static const NativeThrowBehavior MAY = const NativeThrowBehavior._(2);
+  static const NativeThrowBehavior MUST = const NativeThrowBehavior._(3);
+
+  final int _bits;
+  const NativeThrowBehavior._(this._bits);
+
+  String toString() {
+    if (this == NEVER) return 'never';
+    if (this == MAY) return 'may';
+    if (this == MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS) return 'null(1)';
+    if (this == MUST) return 'must';
+    return 'NativeThrowBehavior($_bits)';
+  }
+}
+
 /**
  * A summary of the behavior of a native element.
  *
  * Native code can return values of one type and cause native subtypes of
  * another type to be instantiated.  By default, we compute both from the
  * declared type.
  *
  * A field might yield any native type that 'is' the field type.
  *
  * A method might create and return instances of native subclasses of its
@@ skipping 24 matching lines @@
 
   /// [DartType]s or [SpecialType]s instantiated by the native element.
   final List typesInstantiated = [];
 
   // If this behavior is for a JS expression, [codeTemplate] contains the
   // parsed tree.
   js.Template codeTemplate;
 
   final SideEffects sideEffects = new SideEffects.empty();
 
+  NativeThrowBehavior throwBehavior = NativeThrowBehavior.MAY;
+
+  bool isAllocation = false;
+  bool useGvn = false;
+
   String toString() {
-    return 'NativeBehavior(returns: ${typesReturned}, '
+    return 'NativeBehavior('
+        'returns: ${typesReturned}, '
         'creates: ${typesInstantiated}, '
-        'sideEffects: ${sideEffects})';
+        'sideEffects: ${sideEffects}, '
+        'throws: ${throwBehavior}'
+        '${isAllocation ? ", isAllocation" : ""}'
+        '${useGvn ? ", useGvn" : ""}'
+        ')';
   }
 
 
   /// Processes the type specification string of a call to JS and stores the
   /// result in the [typesReturned] and [typesInstantiated]. It furthermore
   /// computes the side effects, and, if given, invokes [setSideEffects] with
   /// the computed effects. If no side effects are encoded in the [specString]
   /// the [setSideEffects] method is not invoked.
   ///
   /// Two forms of the string is supported:
+  ///
   /// 1) A single type string of the form 'void', '', 'var' or 'T1|...|Tn'
   ///    which defines the types returned and for the later form also created by
   ///    the call to JS.
-  /// 2) A sequence of the form
-  ///    '<type-tag>:<type-string>;<effect-tag>:<effect-string>'
-  ///    where <type-tag> is either 'returns' or 'creates' and where
-  ///    <type-string> is a type string like in 1). The type string marked by
-  ///    'returns' defines the types returned and 'creates' defines the types
-  ///    created by the call to JS.
   ///
-  ///    The <effect-tag> is either 'effects' or 'depends' and
-  ///    <effect-string> is either 'all', 'none' or a comma-separated list of
-  ///    'no-index', 'no-instance', 'no-static'.
+  /// 2) A sequence of <tag>:<value> pairs of the following kinds
+  ///
+  ///        <type-tag>:<type-string>
+  ///        <effect-tag>:<effect-string>
+  ///        throws:<throws-string>
+  ///        gvn:<gvn-string>
+  ///        new:<new-string>
+  ///
+  ///    A <type-tag> is either 'returns' or 'creates' and <type-string> is a
+  ///    type string like in 1). The type string marked by 'returns' defines the
+  ///    types returned and 'creates' defines the types created by the call to
+  ///    JS.
+  ///
+  ///    An <effect-tag> is either 'effects' or 'depends' and <effect-string> is
+  ///    either 'all', 'none' or a comma-separated list of 'no-index',
+  ///    'no-instance', 'no-static'.
   ///
   ///    The flag 'all' indicates that the call affects/depends on every
   ///    side-effect. The flag 'none' indicates that the call does not affect
   ///    (resp. depends on) anything.
   ///
   ///    'no-index' indicates that the call does *not* do any array index-store
   ///    (for 'effects'), or depends on any value in an array (for 'depends').
   ///    The flag 'no-instance' indicates that the call does not modify (resp.
   ///    depends on) any instance variable. Similarly static variables are
   ///    indicated with 'no-static'. The flags 'effects' and 'depends' must be
   ///    used in unison (either both are present or none is).
   ///
+  ///    The <throws-string> values are 'never', 'may', 'must', and 'null(1)'.
+  ///    The default if unspecified is 'may'. 'null(1)' means that the template
+  ///    expression throws if and only if the first template parameter is `null`
+  ///    or `undefined`.
+  ///    TODO(sra): Can we simplify to must/may/never and add null(1) by
+  ///    inspection as an orthongonal attribute?

[floitsch, 2015/04/07 15:35:16]

orthogonal

[sra1, 2015/04/07 17:59:47]

Thanks!

+  ///
+  ///    <gvn-string> values are 'true' and 'false'. The default if unspecified
+  ///    is 'false'.
+  ///
+  ///    <new-string> values are 'true' and 'false'. The default if unspecified
+  ///    is 'false'. A 'true' value means that each evaluation returns a fresh
+  ///    (new) object that cannot be unaliased with existing objects.
+  ///
   ///    Each tag kind (including the 'type-tag's) can only occur once in the
   ///    sequence.
   ///
   /// [specString] is the specification string, [resolveType] resolves named
   /// types into type values, [typesReturned] and [typesInstantiated] collects
   /// the types defined by the specification string, and [objectType] and
   /// [nullType] define the types for `Object` and `Null`, respectively. The
   /// latter is used for the type strings of the form '' and 'var'.
-  // TODO(johnniwinther): Use ';' as a separator instead of a terminator.
+  /// [validTags] can be used to restric

[floitsch, 2015/04/07 15:35:16]

unfinished sentence.

[sra1, 2015/04/07 17:59:47]

Done.

   static void processSpecString(
       DiagnosticListener listener,
       Spannable spannable,
       String specString,
-      {void setSideEffects(SideEffects newEffects),
+      {Iterable<String> validTags,
+       void setSideEffects(SideEffects newEffects),
+       void setThrows(NativeThrowBehavior throwKind),
+       void setIsAllocation(bool isAllocation),
+       void setUseGvn(bool useGvn),
        dynamic resolveType(String typeString),
-       List typesReturned, List typesInstantiated,
+       List typesReturned,
+       List typesInstantiated,
        objectType, nullType}) {
 
+    const List<String> knownTags = const [
+          'creates', 'returns', 'depends', 'effects',
+          'throws', 'gvn', 'new'];
+
     /// Resolve a type string of one of the three forms:
     /// *  'void' - in which case [onVoid] is called,
     /// *  '' or 'var' - in which case [onVar] is called,
-    /// *  'T1|...|Tn' - in which case [onType] is called for each Ti.
+    /// *  'T1|...|Tn' - in which case [onType] is called for each resolved Ti.
     void resolveTypesString(String typesString,
                             {onVoid(), onVar(), onType(type)}) {
       // Various things that are not in fact types.
       if (typesString == 'void') {
         if (onVoid != null) {
           onVoid();
         }
         return;
       }
       if (typesString == '' || typesString == 'var') {
         if (onVar != null) {
           onVar();
         }
         return;
       }
       for (final typeString in typesString.split('|')) {
-        onType(resolveType(typeString));
-      }
-    }
-
-
-    if (specString.contains(':')) {
-      /// Find and remove a substring of the form 'tag:<string>;' from
-      /// [specString].
-      String getTagString(String tag) {
-        String marker = '$tag:';
-        int startPos = specString.indexOf(marker);
-        if (startPos == -1) return null;
-        int endPos = specString.indexOf(';', startPos);
-        if (endPos == -1) return null;
-        String typeString =
-            specString.substring(startPos + marker.length, endPos);
-        specString = '${specString.substring(0, startPos)}'
-                     '${specString.substring(endPos + 1)}'.trim();
-        return typeString;
-      }
-
-      String returns = getTagString('returns');
-      if (returns != null) {
-        resolveTypesString(returns, onVar: () {
-          typesReturned.add(objectType);
-          typesReturned.add(nullType);
-        }, onType: (type) {
-          typesReturned.add(type);
-        });
-      }
-
-      String creates = getTagString('creates');
-      if (creates != null) {
-        resolveTypesString(creates, onVoid: () {
-          listener.internalError(spannable,
-              "Invalid type string 'creates:$creates'");
-        }, onVar: () {
-          listener.internalError(spannable,
-              "Invalid type string 'creates:$creates'");
-        }, onType: (type) {
-          typesInstantiated.add(type);
-        });
-      }
-
-      String effects = getTagString('effects');
-      String depends = getTagString('depends');
-      if (effects != null && depends == null ||
-          effects == null && depends != null) {
-        listener.internalError(spannable,
-            "Invalid JS spec string. "
-            "'effects' and 'depends' must occur together.");
-      }
-
-      if (effects != null) {
-        SideEffects sideEffects = new SideEffects();
-        if (effects == "none") {
-          sideEffects.clearAllSideEffects();
-        } else if (effects == "all") {
-          // Don't do anything.
-        } else {
-          List<String> splitEffects = effects.split(",");
-          if (splitEffects.isEmpty) {
-            listener.internalError(spannable, "Missing side-effect flag.");
-          }
-          for (String effect in splitEffects) {
-            switch (effect) {
-              case "no-index":
-                sideEffects.clearChangesIndex();
-                break;
-              case "no-instance":
-                sideEffects.clearChangesInstanceProperty();
-                break;
-              case "no-static":
-                sideEffects.clearChangesStaticProperty();
-                break;
-              default:
-                listener.internalError(spannable,
-                    "Unrecognized side-effect flag: $effect.");
-            }
-          }
-        }
-
-        if (depends == "none") {
-          sideEffects.clearAllDependencies();
-        } else if (depends == "all") {
-          // Don't do anything.
-        } else {
-          List<String> splitDependencies = depends.split(",");
-          if (splitDependencies.isEmpty) {
-            listener.internalError(spannable,
-                                   "Missing side-effect dependency flag.");
-          }
-          for (String dependency in splitDependencies) {
-            switch (dependency) {
-              case "no-index":
-                sideEffects.clearDependsOnIndexStore();
-                break;
-              case "no-instance":
-                sideEffects.clearDependsOnInstancePropertyStore();
-                break;
-              case "no-static":
-                sideEffects.clearDependsOnStaticPropertyStore();
-                break;
-              default:
-                listener.internalError(spannable,
-                    "Unrecognized side-effect flag: $dependency.");
-            }
-          }
-        }
-
-        setSideEffects(sideEffects);
-      }
-
-      if (!specString.isEmpty) {
-        listener.internalError(spannable, "Invalid JS spec string.");
-      }
-    } else {
-      resolveTypesString(specString, onVar: () {
+        onType(resolveType(typeString.trim()));
+      }
+    }
+
+    if (!specString.contains(';') && !specString.contains(':')) {
+      // Form (1), types or pseudo-types like 'void' and 'var'.
+      resolveTypesString(specString.trim(), onVar: () {
         typesReturned.add(objectType);
         typesReturned.add(nullType);
       }, onType: (type) {
         typesInstantiated.add(type);
         typesReturned.add(type);
       });
-    }
+      return;
+    }
+
+    List<String> specs = specString.split(';')
+        .map((s) => s.trim())
+        .toList();
+    if (specs.last == "") specs.removeLast();  // Allow separator to terminate.
+
+    assert(validTags == null || validTags.toSet().removeAll(validTags).isEmpty);
+    if (validTags == null) validTags = knownTags;
+
+    Map<String, String> values = <String, String>{};
+
+    for (String spec in specs) {
+      List<String> tagAndValue = spec.split(':');
+      if (tagAndValue.length != 2) {
+        listener.internalError(spannable,
+            "Invalid <tag>:<value> pair '$spec'.");
+      }
+      String tag = tagAndValue[0].trim();
+      String value = tagAndValue[1].trim();
+
+      if (validTags.contains(tag)) {
+        if (values[tag] == null) {
+          values[tag] = value;
+        } else {
+          listener.internalError(spannable, "Duplicate tag '$tag'.");
+        }
+      } else {
+        if (knownTags.contains(tag)) {
+          listener.internalError(spannable, "Tag '$tag' is not valid here.");
+        } else {
+          listener.internalError(spannable, "Unknown tag '$tag'.");
+        }
+      }
+    }
+
+    String returns = values['returns'];
+    if (returns != null) {
+      resolveTypesString(returns, onVar: () {
+        typesReturned.add(objectType);
+        typesReturned.add(nullType);
+      }, onType: (type) {
+        typesReturned.add(type);
+      });
+    }
+
+    String creates = values['creates'];
+    if (creates != null) {
+      resolveTypesString(creates, onVoid: () {
+        listener.internalError(spannable,
+            "Invalid type string 'creates:$creates'");
+      }, onVar: () {
+        listener.internalError(spannable,
+            "Invalid type string 'creates:$creates'");
+      }, onType: (type) {
+        typesInstantiated.add(type);
+      });
+    }
+
+    SideEffects sideEffects = null;
+    NativeThrowBehavior throwsKind = null;
+    bool isAllocation = null;
+    bool useGvn = null;
+
+    String effects = values['effects'];
+    String depends = values['depends'];
+    if (effects != null || depends != null) {
+      sideEffects = processEffects(listener, spannable, effects, depends);
+    }
+
+    String throws = values['throws'];
+    if (throws != null) {
+      const map = const <String, NativeThrowBehavior>{
+         'never': NativeThrowBehavior.NEVER,
+         'null(1)': NativeThrowBehavior.MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS,
+         'may': NativeThrowBehavior.MAY,
+         'must': NativeThrowBehavior.MUST };
+      throwsKind = map[throws];
+      if (throwsKind == null) {
+        listener.internalError(spannable,
+            "Unknown 'throws' specification '$throws'");
+      }
+    }
+
+    String newString = values['new'];
+    if (newString != null) {
+      const map = const<String, bool>{'true': true, 'false': false};

[floitsch, 2015/04/07 15:35:16]

I'm not a fan of the map...
if (newString != "true" && newString != "false") {
  listener.internalError(spannable,
      "Unknown 'new' specification: '$newString'");
}
isAllocation = (newString == 'true');

[sra1, 2015/04/07 17:59:47]

I have moved this to a helper.

+      isAllocation = map[newString];
+      if (isAllocation == null) {
+        listener.internalError(spannable,
+            "Unknown 'new' specification: '$newString'");
+      }
+    }
+
+    String gvn = values['gvn'];
+    if (gvn != null) {
+      const map = const<String, bool>{'true': true, 'false': false};

[floitsch, 2015/04/07 15:35:16]

ditto.

[sra1, 2015/04/07 17:59:47]

Done.

+      useGvn = map[gvn];
+      if (useGvn == null) {
+        listener.internalError(spannable,
+            "Unknown 'gvn' specification: '$gvn'");
+      }
+    }
+
+    if (isAllocation == true && useGvn == true) {
+      listener.internalError(spannable, "'new' and 'gvn' are incompatible");
+    }
+    if (sideEffects != null) setSideEffects(sideEffects);
+    if (throwsKind != null) setThrows(throwsKind);
+    if (isAllocation != null) setIsAllocation(isAllocation);
+    if (useGvn != null) setUseGvn(useGvn);
   }
 
+  static SideEffects processEffects(
+      DiagnosticListener listener,
+      Spannable spannable,
+      String effects,
+      String depends) {
+
+    if (effects == null || depends == null) {
+      listener.internalError(spannable,
+          "Invalid JS spec string. "
+          "'effects' and 'depends' must occur together.");
+      return null;
+    }
+
+    SideEffects sideEffects = new SideEffects();
+    if (effects == "none") {
+      sideEffects.clearAllSideEffects();
+    } else if (effects == "all") {
+      // Don't do anything.
+    } else {
+      List<String> splitEffects = effects.split(",");
+      if (splitEffects.isEmpty) {
+        listener.internalError(spannable, "Missing side-effect flag.");
+      }
+      for (String effect in splitEffects) {
+        switch (effect) {
+          case "no-index":
+            sideEffects.clearChangesIndex();
+            break;
+          case "no-instance":
+            sideEffects.clearChangesInstanceProperty();
+            break;
+          case "no-static":
+            sideEffects.clearChangesStaticProperty();
+            break;
+          default:
+            listener.internalError(spannable,
+                "Unrecognized side-effect flag: '$effect'.");
+        }
+      }
+    }
+
+    if (depends == "none") {
+      sideEffects.clearAllDependencies();
+    } else if (depends == "all") {
+      // Don't do anything.
+    } else {
+      List<String> splitDependencies = depends.split(",");
+      if (splitDependencies.isEmpty) {
+        listener.internalError(spannable,
+            "Missing side-effect dependency flag.");
+      }
+      for (String dependency in splitDependencies) {
+        switch (dependency) {
+          case "no-index":
+            sideEffects.clearDependsOnIndexStore();
+            break;
+          case "no-instance":
+            sideEffects.clearDependsOnInstancePropertyStore();
+            break;
+          case "no-static":
+            sideEffects.clearDependsOnStaticPropertyStore();
+            break;
+          default:
+            listener.internalError(spannable,
+                "Unrecognized side-effect flag: '$dependency'.");
+        }
+      }
+    }
+
+    return sideEffects;
+  }
+
   static NativeBehavior ofJsCall(Send jsCall, Compiler compiler, resolver) {
     // The first argument of a JS-call is a string encoding various attributes
     // of the code.
     //
     //  'Type1|Type2'.  A union type.
     //  '=Object'.      A JavaScript Object, no subtype.
 
     var argNodes = jsCall.arguments;
     if (argNodes.isEmpty) {
       compiler.internalError(jsCall, "JS expression has no type.");
@@ skipping 25 matching lines @@
           jsCall);
     }
 
     bool sideEffectsAreEncodedInSpecString = false;
 
     void setSideEffects(SideEffects newEffects) {
       sideEffectsAreEncodedInSpecString = true;
       behavior.sideEffects.setTo(newEffects);
     }
 
+    bool throwBehaviorFromSpecString = false;
+    void setThrows(NativeThrowBehavior throwBehavior) {
+      throwBehaviorFromSpecString = true;
+      behavior.throwBehavior = throwBehavior;
+    }
+
+    void setIsAllocation(bool isAllocation) {
+      behavior.isAllocation = isAllocation;
+    }
+
+    void setUseGvn(bool useGvn) {
+      behavior.useGvn = useGvn;
+    }
+
     processSpecString(compiler, jsCall,
-                      specString,
-                      setSideEffects: setSideEffects,
-                      resolveType: resolveType,
-                      typesReturned: behavior.typesReturned,
-                      typesInstantiated: behavior.typesInstantiated,
-                      objectType: compiler.objectClass.computeType(compiler),
-                      nullType: compiler.nullClass.computeType(compiler));
+        specString,
+        setSideEffects: setSideEffects,
+        setThrows: setThrows,
+        setIsAllocation: setIsAllocation,
+        useGvn: useGvn,
+        resolveType: resolveType,
+        typesReturned: behavior.typesReturned,
+        typesInstantiated: behavior.typesInstantiated,
+        objectType: compiler.objectClass.computeType(compiler),
+        nullType: compiler.nullClass.computeType(compiler));
 
     if (!sideEffectsAreEncodedInSpecString) {
       new SideEffectsVisitor(behavior.sideEffects)
           .visit(behavior.codeTemplate.ast);
     }
 
+    // TODO(sra): Simplify [throwBehavior] using [sideEffects].
+
     return behavior;
   }
 
   static NativeBehavior ofJsEmbeddedGlobalCall(Send jsGlobalCall,
                                                Compiler compiler,
                                                resolver) {
     // The first argument of a JS-embedded global call is a string encoding
     // the type of the code.
     //
     //  'Type1|Type2'.  A union type.
     //  '=Object'.      A JavaScript Object, no subtype.
 
     Link<Node> argNodes = jsGlobalCall.arguments;
     if (argNodes.isEmpty) {
       compiler.internalError(jsGlobalCall,
           "JS embedded global expression has no type.");
     }
 
     // We don't check the given name. That needs to be done at a later point.
     // This is, because we want to allow non-literals as names.
     if (argNodes.tail.isEmpty) {
-      compiler.internalError(jsGlobalCall, 'Embedded Global is missing name');
+      compiler.internalError(jsGlobalCall, 'Embedded Global is missing name.');
     }
 
     if (!argNodes.tail.tail.isEmpty) {
       compiler.internalError(argNodes.tail.tail.head,
           'Embedded Global has more than 2 arguments');
     }
 
     LiteralString specLiteral = argNodes.head.asLiteralString();
     if (specLiteral == null) {
       // TODO(sra): We could accept a type identifier? e.g. JS(bool, '1<2').  It
       // is not very satisfactory because it does not work for void, dynamic.
       compiler.internalError(argNodes.head, "Unexpected first argument.");
     }
 
     NativeBehavior behavior = new NativeBehavior();
 
     String specString = specLiteral.dartString.slowToString();
 
     dynamic resolveType(String typeString) {
       return _parseType(
           typeString,
           compiler,
           (name) => resolver.resolveTypeFromString(specLiteral, name),
           jsGlobalCall);
     }
 
-    void setSideEffects(SideEffects newEffects) {
-      compiler.internalError(jsGlobalCall,
-          'Embedded global calls may not have any side-effect overwrites: '
-          '$specString');
-    }
-
     processSpecString(compiler, jsGlobalCall,
                       specString,
-                      setSideEffects: setSideEffects,
+                      validTags: const ['returns', 'creates'],
                       resolveType: resolveType,
                       typesReturned: behavior.typesReturned,
                       typesInstantiated: behavior.typesInstantiated,
                       objectType: compiler.objectClass.computeType(compiler),
                       nullType: compiler.nullClass.computeType(compiler));
 
     return behavior;
   }
 
   static NativeBehavior ofMethod(FunctionElement method, Compiler compiler) {
@@ skipping 154 matching lines @@
         _errorNode(locationNodeOrElement, compiler),
         "Type '$typeString' not found.");
     return null;
   }
 
   static _errorNode(locationNodeOrElement, compiler) {
     if (locationNodeOrElement is Node) return locationNodeOrElement;
     return locationNodeOrElement.parseNode(compiler);
   }
 }