Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1026093002: Fix hints in the analyzer package. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix hints in the analyzer package. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -131 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 40 chunks +43 lines, -43 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 16 chunks +29 lines, -29 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 12 chunks +16 lines, -16 lines 0 comments Download
M pkg/analyzer/test/reflective_tests.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-23 17:23:47 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-23 17:32:48 UTC) #2
scheglov
5 years, 9 months ago (2015-03-23 17:34:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698