Fix hints in the analyzer package.

pkg/analyzer/test/generated/utilities_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.utilities_test;
 
 import 'dart:collection';
@@ skipping 1571 matching lines @@
     }
   }
 }
 
 @reflectiveTest
 class BooleanArrayTest {
   void test_get_negative() {
     try {
       BooleanArray.get(0, -1);
       fail("Expected ");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_get_tooBig() {
     try {
       BooleanArray.get(0, 31);
       fail("Expected ");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_get_valid() {
     expect(BooleanArray.get(0, 0), false);
     expect(BooleanArray.get(1, 0), true);
     expect(BooleanArray.get(0, 30), false);
     expect(BooleanArray.get(1 << 30, 30), true);
   }
 
   void test_set_negative() {
     try {
       BooleanArray.set(0, -1, true);
       fail("Expected ");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_set_tooBig() {
     try {
       BooleanArray.set(0, 32, true);
       fail("Expected ");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_set_valueChanging() {
     expect(BooleanArray.set(0, 0, true), 1);
     expect(BooleanArray.set(1, 0, false), 0);
     expect(BooleanArray.set(0, 30, true), 1 << 30);
     expect(BooleanArray.set(1 << 30, 30, false), 0);
   }
@@ skipping 127 matching lines @@
     expect(cycle, hasLength(1));
     expect(cycle[0], node);
   }
 
   void test_findCycleContaining_null() {
     DirectedGraph<DirectedGraphTest_Node> graph =
         new DirectedGraph<DirectedGraphTest_Node>();
     try {
       graph.findCycleContaining(null);
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_findCycleContaining_singleton() {
     DirectedGraphTest_Node node1 = new DirectedGraphTest_Node();
     DirectedGraphTest_Node node2 = new DirectedGraphTest_Node();
     DirectedGraphTest_Node node3 = new DirectedGraphTest_Node();
     DirectedGraph<DirectedGraphTest_Node> graph =
         new DirectedGraph<DirectedGraphTest_Node>();
@@ skipping 998 matching lines @@
 @reflectiveTest
 class LineInfoTest {
   void test_creation() {
     expect(new LineInfo(<int>[0]), isNotNull);
   }
 
   void test_creation_empty() {
     try {
       new LineInfo(<int>[]);
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_creation_null() {
     try {
       new LineInfo(null);
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_firstLine() {
     LineInfo info = new LineInfo(<int>[0, 12, 34]);
     LineInfo_Location location = info.getLocation(4);
     expect(location.lineNumber, 1);
     expect(location.columnNumber, 5);
   }
@@ skipping 374 matching lines @@
     expect(iterator.moveNext(), isFalse);
   }
 
   void test_singleMap_empty() {
     Map<String, String> map = new HashMap<String, String>();
     MultipleMapIterator<String, String> iterator = _iterator(<Map>[map]);
     expect(iterator.moveNext(), isFalse);
     try {
       iterator.key;
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
     try {
       iterator.value;
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
     try {
       iterator.value = "x";
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
   }
 
   void test_singleMap_multiple() {
     Map<String, String> map = new HashMap<String, String>();
     map["k1"] = "v1";
     map["k2"] = "v2";
     map["k3"] = "v3";
     MultipleMapIterator<String, String> iterator = _iterator([map]);
@@ skipping 924 matching lines @@
 @reflectiveTest
 class SingleMapIteratorTest extends EngineTestCase {
   void test_empty() {
     Map<String, String> map = new HashMap<String, String>();
     SingleMapIterator<String, String> iterator =
         new SingleMapIterator<String, String>(map);
     expect(iterator.moveNext(), isFalse);
     try {
       iterator.key;
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
     try {
       iterator.value;
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
     try {
       iterator.value = "x";
       fail("Expected NoSuchElementException");
-    } on NoSuchElementException catch (exception) {
+    } on NoSuchElementException {
       // Expected
     }
     expect(iterator.moveNext(), isFalse);
   }
 
   void test_multiple() {
     Map<String, String> map = new HashMap<String, String>();
     map["k1"] = "v1";
     map["k2"] = "v2";
     map["k3"] = "v3";
@@ skipping 262 matching lines @@
     expect(StringUtilities.isTagName("a0"), isTrue);
     expect(StringUtilities.isTagName("a"), isTrue);
     expect(StringUtilities.isTagName("ab"), isTrue);
     expect(StringUtilities.isTagName("a-b"), isTrue);
   }
 
   void test_printListOfQuotedNames_empty() {
     try {
       StringUtilities.printListOfQuotedNames(new List<String>(0));
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_printListOfQuotedNames_five() {
     expect(StringUtilities
             .printListOfQuotedNames(<String>["a", "b", "c", "d", "e"]),
         "'a', 'b', 'c', 'd' and 'e'");
   }
 
   void test_printListOfQuotedNames_null() {
     try {
       StringUtilities.printListOfQuotedNames(null);
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_printListOfQuotedNames_one() {
     try {
       StringUtilities.printListOfQuotedNames(<String>["a"]);
       fail("Expected IllegalArgumentException");
-    } on IllegalArgumentException catch (exception) {
+    } on IllegalArgumentException {
       // Expected
     }
   }
 
   void test_printListOfQuotedNames_three() {
     expect(StringUtilities.printListOfQuotedNames(<String>["a", "b", "c"]),
         "'a', 'b' and 'c'");
   }
 
   void test_printListOfQuotedNames_two() {
@@ skipping 106 matching lines @@
   }
 
   void test_get_added() {
     TokenMap tokenMap = new TokenMap();
     Token key = TokenFactory.tokenFromType(TokenType.AT);
     Token value = TokenFactory.tokenFromType(TokenType.AT);
     tokenMap.put(key, value);
     expect(tokenMap.get(key), same(value));
   }
 }