Fix hints in the analyzer package.

pkg/analyzer/test/generated/ast_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.ast_test;
 
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 710 matching lines @@
     expect(firstNode.parent, same(parent));
     expect(secondNode.parent, same(parent));
     expect(thirdNode.parent, same(parent));
   }
 
   void test_add_negative() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list.insert(-1, AstFactory.booleanLiteral(true));
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_add_tooBig() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list.insert(1, AstFactory.booleanLiteral(true));
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_addAll() {
     AstNode parent = AstFactory.argumentList();
     List<AstNode> firstNodes = new List<AstNode>();
     AstNode firstNode = AstFactory.booleanLiteral(true);
     AstNode secondNode = AstFactory.booleanLiteral(false);
     firstNodes.add(firstNode);
@@ skipping 28 matching lines @@
     expect(list, isNotNull);
     expect(list, hasLength(0));
     expect(list.owner, same(owner));
   }
 
   void test_get_negative() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list[-1];
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_get_tooBig() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list[1];
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_getBeginToken_empty() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     expect(list.beginToken, isNull);
   }
 
   void test_getBeginToken_nonEmpty() {
@@ skipping 51 matching lines @@
     expect(list, hasLength(2));
     expect(list[0], same(firstNode));
     expect(list[1], same(thirdNode));
   }
 
   void test_remove_negative() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list.removeAt(-1);
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_remove_tooBig() {
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       list.removeAt(1);
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_set() {
     List<AstNode> nodes = new List<AstNode>();
     AstNode firstNode = AstFactory.booleanLiteral(true);
     AstNode secondNode = AstFactory.booleanLiteral(false);
     AstNode thirdNode = AstFactory.booleanLiteral(true);
     nodes.add(firstNode);
     nodes.add(secondNode);
     nodes.add(thirdNode);
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     list.addAll(nodes);
     expect(list, hasLength(3));
     AstNode fourthNode = AstFactory.integer(0);
     expect(javaListSet(list, 1, fourthNode), same(secondNode));
     expect(list, hasLength(3));
     expect(list[0], same(firstNode));
     expect(list[1], same(fourthNode));
     expect(list[2], same(thirdNode));
   }
 
   void test_set_negative() {
     AstNode node = AstFactory.booleanLiteral(true);
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       javaListSet(list, -1, node);
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 
   void test_set_tooBig() {
     AstNode node = AstFactory.booleanLiteral(true);
     NodeList<AstNode> list = new NodeList<AstNode>(AstFactory.argumentList());
     try {
       javaListSet(list, 1, node);
       fail("Expected IndexOutOfBoundsException");
-    } on RangeError catch (exception) {
+    } on RangeError {
       // Expected
     }
   }
 }
 
 @reflectiveTest
 class NodeLocatorTest extends ParserTestCase {
   void test_range() {
     CompilationUnit unit =
         ParserTestCase.parseCompilationUnit("library myLib;");
@@ skipping 2305 matching lines @@
   static const List<WrapperKind> values = const [
     PREFIXED_LEFT,
     PREFIXED_RIGHT,
     PROPERTY_LEFT,
     PROPERTY_RIGHT,
     NONE
   ];
 
   const WrapperKind(String name, int ordinal) : super(name, ordinal);
 }