Issue 1016503005: Rename NoGCScope -> NoSafepointScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1016503005: Rename NoGCScope -> NoSafepointScope. (Closed)

Created:
5 years, 9 months ago by koda

Modified:
5 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rename NoGCScope -> NoSafepointScope. The old name makes less sense in the context of concurrent GC (and multiple threads in general). Document the intended semantics of this (DEBUG-only) guard scope. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44616

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -238 lines)			Patch
M	runtime/lib/string.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/base_isolate.h	View	1	3 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		20 chunks	+21 lines, -21 lines	0 comments	Download
M	runtime/vm/disassembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/hash_table_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/heap.h	View		2 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1	6 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1	20 chunks	+27 lines, -27 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	104 chunks	+105 lines, -105 lines	0 comments	Download
M	runtime/vm/object_graph.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/object_graph_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/profiler_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/runtime_entry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1	22 chunks	+22 lines, -22 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/verifier.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

5 years, 9 months ago (2015-03-20 22:08:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44616 (presubmit successful).

Expand Messages | Collapse Messages