Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: runtime/vm/heap.h

Issue 1016503005: Rename NoGCScope -> NoSafepointScope. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/hash_table_test.cc ('k') | runtime/vm/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.h
===================================================================
--- runtime/vm/heap.h (revision 44579)
+++ runtime/vm/heap.h (working copy)
@@ -125,7 +125,8 @@
// point.
// The 'visitor' function should return false if the object is not found,
// traversal through the heap space continues.
- // Returns null object if nothing is found. Must be called within a NoGCScope.
+ // Returns null object if nothing is found. Must be called within a
+ // NoSafepointScope.
RawInstructions* FindObjectInCodeSpace(FindObjectVisitor* visitor) const;
RawObject* FindOldObject(FindObjectVisitor* visitor) const;
RawObject* FindNewObject(FindObjectVisitor* visitor) const;
@@ -335,20 +336,22 @@
};
+// Within a NoSafepointScope, the thread must not reach any safepoint. Used
+// around code that manipulates raw object pointers directly without handles.
#if defined(DEBUG)
-class NoGCScope : public StackResource {
+class NoSafepointScope : public StackResource {
public:
- NoGCScope();
- ~NoGCScope();
+ NoSafepointScope();
+ ~NoSafepointScope();
private:
- DISALLOW_COPY_AND_ASSIGN(NoGCScope);
+ DISALLOW_COPY_AND_ASSIGN(NoSafepointScope);
};
#else // defined(DEBUG)
-class NoGCScope : public ValueObject {
+class NoSafepointScope : public ValueObject {
public:
- NoGCScope() {}
+ NoSafepointScope() {}
private:
- DISALLOW_COPY_AND_ASSIGN(NoGCScope);
+ DISALLOW_COPY_AND_ASSIGN(NoSafepointScope);
};
#endif // defined(DEBUG)
« no previous file with comments | « runtime/vm/hash_table_test.cc ('k') | runtime/vm/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698