Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: runtime/vm/verifier.cc

Issue 1016503005: Rename NoGCScope -> NoSafepointScope. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/stack_frame.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/verifier.h" 5 #include "vm/verifier.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/dart.h" 8 #include "vm/dart.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/freelist.h" 10 #include "vm/freelist.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 void VerifyWeakPointersVisitor::VisitHandle(uword addr) { 61 void VerifyWeakPointersVisitor::VisitHandle(uword addr) {
62 FinalizablePersistentHandle* handle = 62 FinalizablePersistentHandle* handle =
63 reinterpret_cast<FinalizablePersistentHandle*>(addr); 63 reinterpret_cast<FinalizablePersistentHandle*>(addr);
64 RawObject* raw_obj = handle->raw(); 64 RawObject* raw_obj = handle->raw();
65 visitor_->VisitPointer(&raw_obj); 65 visitor_->VisitPointer(&raw_obj);
66 } 66 }
67 67
68 68
69 void VerifyPointersVisitor::VerifyPointers(MarkExpectation mark_expectation) { 69 void VerifyPointersVisitor::VerifyPointers(MarkExpectation mark_expectation) {
70 NoGCScope no_gc; 70 NoSafepointScope no_safepoint;
71 Isolate* isolate = Isolate::Current(); 71 Isolate* isolate = Isolate::Current();
72 ObjectSet* allocated_set = 72 ObjectSet* allocated_set =
73 isolate->heap()->CreateAllocatedObjectSet(mark_expectation); 73 isolate->heap()->CreateAllocatedObjectSet(mark_expectation);
74 VerifyPointersVisitor visitor(isolate, allocated_set); 74 VerifyPointersVisitor visitor(isolate, allocated_set);
75 // Visit all strongly reachable objects. 75 // Visit all strongly reachable objects.
76 isolate->VisitObjectPointers(&visitor, 76 isolate->VisitObjectPointers(&visitor,
77 false, // skip prologue weak handles 77 false, // skip prologue weak handles
78 StackFrameIterator::kValidateFrames); 78 StackFrameIterator::kValidateFrames);
79 VerifyWeakPointersVisitor weak_visitor(&visitor); 79 VerifyWeakPointersVisitor weak_visitor(&visitor);
80 // Visit weak handles and prologue weak handles. 80 // Visit weak handles and prologue weak handles.
81 isolate->VisitWeakPersistentHandles(&weak_visitor, 81 isolate->VisitWeakPersistentHandles(&weak_visitor,
82 true); // visit prologue weak handles 82 true); // visit prologue weak handles
83 delete allocated_set; 83 delete allocated_set;
84 } 84 }
85 85
86 } // namespace dart 86 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/stack_frame.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698