Issue 9959103: Fix for an issue where reported line positions on windows files were off by a factor of 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959103: Fix for an issue where reported line positions on windows files were off by a factor of 2. (Closed)

Created:
8 years, 8 months ago by devoncarew

Modified:
8 years, 8 months ago

Reviewers:
scheglov, zundel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix for an issue where reported line positions on windows files were off by a factor of 2. Committed: https://code.google.com/p/dart/source/detail?r=6130

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	compiler/java/com/google/dart/compiler/UrlSource.java	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	compiler/java/com/google/dart/compiler/common/SourceInfo.java	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

devoncarew

fix for http://code.google.com/p/dart/issues/detail?id=2341

8 years, 8 months ago (2012-04-03 17:38:52 UTC) #1

lgtm