compiler/java/com/google/dart/compiler/common/SourceInfo.java - Issue 9959103: Fix for an issue where reported line positions on windows files were off by a factor of 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/common/SourceInfo.java

Issue 9959103: Fix for an issue where reported line positions on windows files were off by a factor of 2. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/common/SourceInfo.java

===================================================================

--- compiler/java/com/google/dart/compiler/common/SourceInfo.java (revision 6128)

+++ compiler/java/com/google/dart/compiler/common/SourceInfo.java (working copy)

@@ -71,7 +71,6 @@

try {

reader = new BufferedReader(source.getSourceReader());

int offset = 0;

- boolean ignoreLF = false;

List<Integer> lineOffsets = Lists.newArrayList(0);

while (true) {

int charValue = reader.read();

@@ -80,8 +79,7 @@

}

offset++;

char c = (char) charValue;

- ignoreLF = c == '\n';

- if (c == '\n' || c == '\r' && !ignoreLF) {

+ if (c == '\n') {

lineOffsets.add(offset);

}

« no previous file with comments | « compiler/java/com/google/dart/compiler/UrlSource.java ('k') | no next file » | no next file with comments »