Issue 99237: Correct omnibox2 popup placement for RTL languages....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99237: Correct omnibox2 popup placement for RTL languages.... (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
xji

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Correct omnibox2 popup placement for RTL languages. Xiaomei, I just applied the code that you suggested in your email and it worked. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14974

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/views/toolbar_view.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

xji

11 years, 7 months ago (2009-04-30 19:28:15 UTC) #2

LGTM, except the lint error.

On 2009/04/30 19:21:19, Ben Goodger wrote:
>