Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/toolbar_view.cc

Issue 99237: Correct omnibox2 popup placement for RTL languages.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/toolbar_view.cc
===================================================================
--- chrome/browser/views/toolbar_view.cc (revision 14954)
+++ chrome/browser/views/toolbar_view.cc (working copy)
@@ -872,7 +872,10 @@
gfx::Rect popup_bounds(origin.x(), origin.y(),
star_->width() + location_bar_->width() + go_->width(),
0);
- popup_bounds.set_x(popup_bounds.x());
+ if (UILayoutIsRightToLeft())
+ popup_bounds.set_x(popup_bounds.x() - location_bar_->width() - go_->width());
+ else
+ popup_bounds.set_x(popup_bounds.x());
popup_bounds.set_y(popup_bounds.y());
popup_bounds.set_width(popup_bounds.width());
// Inset the bounds a little, since the buttons on either edge of the omnibox
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698