Correct omnibox2 popup placement for RTL languages....

chrome/browser/views/toolbar_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/toolbar_view.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 854 matching lines @@
       event_utils::DispositionFromEventFlags(sender->mouse_event_flags()));
 }
 
 gfx::Rect BrowserToolbarView::GetPopupBounds() const {
   gfx::Point origin;
   views::View::ConvertPointToScreen(star_, &origin);
   origin.set_y(origin.y() + star_->height() + kOmniboxPopupVerticalSpacing);
   gfx::Rect popup_bounds(origin.x(), origin.y(),
                          star_->width() + location_bar_->width() + go_->width(),
                          0);
-  popup_bounds.set_x(popup_bounds.x());
+  if (UILayoutIsRightToLeft())
+    popup_bounds.set_x(popup_bounds.x() - location_bar_->width() - go_->width());
+  else
+    popup_bounds.set_x(popup_bounds.x());
   popup_bounds.set_y(popup_bounds.y());
   popup_bounds.set_width(popup_bounds.width());
   // Inset the bounds a little, since the buttons on either edge of the omnibox
   // have invisible padding that makes the popup appear too wide.
   popup_bounds.Inset(kOmniboxButtonsHorizontalMargin, 0);
   return popup_bounds;
 }
 
 // static
 int BrowserToolbarView::PopupTopSpacing() {
@@ skipping 25 matching lines @@
     case IDC_COPY:
       *accel = views::Accelerator(L'C', false, true, false);
       return true;
     case IDC_PASTE:
       *accel = views::Accelerator(L'V', false, true, false);
       return true;
   }
   // Else, we retrieve the accelerator information from the frame.
   return GetWidget()->GetAccelerator(id, accel);
 }