Suppress a GTK warning and file a bug for it.

Suppress a GTK warning and file a bug for it.

BUG=11133
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14811

[Evan Martin, 2009-04-28 21:13:15]

http://codereview.chromium.org/99153/diff/1/2
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/99153/diff/1/2#newcode162
Line 162: // http://crbug.com/9643
I think the other (original) URL style is better here and below.  The short one
is just for typing.

http://codereview.chromium.org/99153/diff/1/2#newcode173
Line 173: gtk_check_version(2, 16, 1)) {
Why not GTK_CHECK_VERSION?
"Returns TRUE if the version of the GTK+ header files is the same as or newer
than the passed-in version."

I wonder if this will run into trouble with translated messages... :(

[Evan Stade, 2009-04-28 21:23:51]

http://codereview.chromium.org/99153/diff/1/2
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/99153/diff/1/2#newcode162
Line 162: // http://crbug.com/9643
On 2009/04/28 21:13:16, Evan Martin wrote:
> I think the other (original) URL style is better here and below.  The short
one
> is just for typing.

I don't see why. The short form seems easier to read. Is crbug.com likely to go
away?

A grep of src/chrome/ shows 62 instances of the short form and 44 of the long
form.

http://codereview.chromium.org/99153/diff/1/2#newcode173
Line 173: gtk_check_version(2, 16, 1)) {
On 2009/04/28 21:13:16, Evan Martin wrote:
> Why not GTK_CHECK_VERSION?
> "Returns TRUE if the version of the GTK+ header files is the same as or newer
> than the passed-in version."
> 
> I wonder if this will run into trouble with translated messages... :(

Done.

[Evan Martin, 2009-04-28 21:39:51]

OK

http://codereview.chromium.org/99153/diff/1/2
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/99153/diff/1/2#newcode169
Line 169: // gtk_check_version() will return NULL if the current version is >=
the
be sure to remove this comment once you use the macro.

I think it would be less confusing to have the bug link inside the else branch,
but that's your call.