Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: chrome/app/chrome_dll_main.cc

Issue 99153: Suppress a GTK warning and file a bug for it. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_dll_main.cc
===================================================================
--- chrome/app/chrome_dll_main.cc (revision 14624)
+++ chrome/app/chrome_dll_main.cc (working copy)
@@ -159,12 +159,19 @@
if (!message)
message = "<no message>";
- // http://code.google.com/p/chromium/issues/detail?id=9643
+ // http://crbug.com/9643
Evan Martin 2009/04/28 21:13:16 I think the other (original) URL style is better h
Evan Stade 2009/04/28 21:23:51 I don't see why. The short form seems easier to re
// Until we have a real 64-bit build or all of these 32-bit package issues
// are sorted out, don't fatal on ELF 32/64-bit mismatch warnings.
if (strstr(message, "Loading IM context type") ||
strstr(message, "wrong ELF class: ELFCLASS64")) {
LOG(ERROR) << "Bug 9643: " << log_domain << ": " << message;
+ // http://crbug.com/11133
+ // gtk_check_version() will return NULL if the current version is >= the
Evan Martin 2009/04/28 21:39:51 be sure to remove this comment once you use the ma
+ // passed version.
+ } else if (strstr(message, "gtk_widget_size_allocate(): attempt to "
+ "allocate widget with width") &&
+ gtk_check_version(2, 16, 1)) {
Evan Martin 2009/04/28 21:13:16 Why not GTK_CHECK_VERSION? "Returns TRUE if the ve
Evan Stade 2009/04/28 21:23:51 Done.
+ LOG(ERROR) << "Bug 11133";
} else {
LOG(FATAL) << log_domain << ": " << message;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698