Suppress a GTK warning and file a bug for it.

chrome/app/chrome_dll_main.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(port): the ifdefs in here are a first step towards trying to determine
 // the correct abstraction for all the OS functionality required at this
 // stage of process initialization. It should not be taken as a final
 // abstraction.
 
 #include "build/build_config.h"
@@ skipping 141 matching lines @@
 #if defined(OS_LINUX)
 static void GLibLogHandler(const gchar* log_domain,
                            GLogLevelFlags log_level,
                            const gchar* message,
                            gpointer userdata) {
   if (!log_domain)
     log_domain = "<unknown>";
   if (!message)
     message = "<no message>";
 
-  // http://code.google.com/p/chromium/issues/detail?id=9643
+  // http://crbug.com/9643

[Evan Martin, 2009/04/28 21:13:16]

I think the other (original) URL style is better here and below.  The short one
is just for typing.

[Evan Stade, 2009/04/28 21:23:51]

I don't see why. The short form seems easier to read. Is crbug.com likely to go
away?

A grep of src/chrome/ shows 62 instances of the short form and 44 of the long
form.

   // Until we have a real 64-bit build or all of these 32-bit package issues
   // are sorted out, don't fatal on ELF 32/64-bit mismatch warnings.
   if (strstr(message, "Loading IM context type") ||
       strstr(message, "wrong ELF class: ELFCLASS64")) {
     LOG(ERROR) << "Bug 9643: " << log_domain << ": " << message;
+  // http://crbug.com/11133
+  // gtk_check_version() will return NULL if the current version is >= the

[Evan Martin, 2009/04/28 21:39:51]

be sure to remove this comment once you use the macro.

I think it would be less confusing to have the bug link inside the else branch,
but that's your call.

+  // passed version.
+  } else if (strstr(message, "gtk_widget_size_allocate(): attempt to "
+                             "allocate widget with width") &&
+             gtk_check_version(2, 16, 1)) {

[Evan Martin, 2009/04/28 21:13:16]

Why not GTK_CHECK_VERSION?
"Returns TRUE if the version of the GTK+ header files is the same as or newer
than the passed-in version."

I wonder if this will run into trouble with translated messages... :(

[Evan Stade, 2009/04/28 21:23:51]

Done.

+    LOG(ERROR) << "Bug 11133";
   } else {
     LOG(FATAL) << log_domain << ": " << message;
   }
 }
 
 static void SetUpGLibLogHandler() {
   // Register GLib-handled assertions to go through our logging system.
   const char* kLogDomains[] = { NULL, "Gtk", "Gdk", "GLib" };
   for (size_t i = 0; i < arraysize(kLogDomains); i++) {
     g_log_set_handler(kLogDomains[i],
@@ skipping 291 matching lines @@
   _CrtDumpMemoryLeaks();
 #endif  // _CRTDBG_MAP_ALLOC
 
   _Module.Term();
 #endif
 
   logging::CleanupChromeLogging();
 
   return rv;
 }