Issue 9845034: Revert [SQLite] Hack to touch page cache to debug slow connection close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9845034: Revert [SQLite] Hack to touch page cache to debug slow connection close. (Closed)

Created:
8 years, 9 months ago by Scott Hess - ex-Googler

Modified:
8 years, 7 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert [SQLite] Hack to touch page cache to debug slow connection close. Original CL http://codereview.chromium.org/7891025 , http://crrev.com/101034 The hypothesis discussed in that CL seems proven out, as the shutdown-hang crashes mostly moved from sqlite3_close() into sqlite3_95527(). BUG=95527 TEST=Monitor crash in bug, see if it changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137989

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -121 lines)			Patch
M	sql/connection.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	third_party/sqlite/amalgamation/sqlite3.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	third_party/sqlite/amalgamation/sqlite3.c	View	1 chunk	+0 lines, -91 lines	0 comments	Download

Total messages: 4 (0 generated)

Scott Hess - ex-Googler

Per earlier discussion, I'm thinking of putting some other hacks into sqlite3.c to measure memory ...

8 years, 9 months ago (2012-03-23 19:54:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/9845034/1

8 years, 7 months ago (2012-05-18 21:18:57 UTC) #3

Change committed as 137989