Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 7891025: [SQLite] Hack to touch page cache to debug slow connection close. (Closed)

Created:
9 years, 3 months ago by Scott Hess - ex-Googler
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[SQLite] Hack to touch page cache to debug slow connection close. The shutdown-monitor has noted cases where sqlite3_close() is taking a very long time to finish. In reviewing the code, writes are committed before the close is called, so there should be almost no I/O involved (excepting perhaps unlocking the file?). One hypothesis is that the SQLite page cache, which is LRU, may have very old pages which have been paged out. This change touches them all, so if they are paged out the crash should move to this code. BUG=95527 TEST=Monitor crash in bug, see if it changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101034

Patch Set 1 #

Patch Set 2 : Fix Windows compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M sql/connection.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.h View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.c View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
This is a little hacky, but we shouldn't retain it for long, right? Putting it ...
9 years, 3 months ago (2011-09-13 23:15:17 UTC) #1
ramant (doing other things)
LGTM scott. thanks
9 years, 3 months ago (2011-09-14 01:06:34 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-14 06:37:49 UTC) #3
Change committed as 101034

Powered by Google App Engine
This is Rietveld 408576698