Issue 9839075: chromeos: Separate CrosDBusService Initialize/Shutdown from DBusThreadManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9839075: chromeos: Separate CrosDBusService Initialize/Shutdown from DBusThreadManager (Closed)

Created:
8 years, 9 months ago by hashimoto

Modified:
8 years, 9 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

chromeos: Separate CrosDBusService Initialize/Shutdown from DBusThreadManager To remove DBusThreadManager's dependency to CrosDBusService BUG=119583 TEST=dbus-send --system --dest=org.chromium.LibCrosService --type=method_call --print-reply /org/chromium/LibCrosService org.chromium.LibCrosServiceInterface.ResolveNetworkProxy string:www.chromium.org string:AAA string:BBB Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128700

Patch Set 1 #

Patch Set 2 : Rebased onto ToT #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -33 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/cros_dbus_service.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/cros_dbus_service.cc	View	4 chunks	+34 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/dbus_thread_manager.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9839075/3002

8 years, 9 months ago (2012-03-24 02:34:00 UTC) #3

Change committed as 128700

Expand Messages | Collapse Messages