chromeos: Separate CrosDBusService Initialize/Shutdown from DBusThreadManager

chrome/browser/chromeos/dbus/cros_dbus_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/dbus/cros_dbus_service.h"
 
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/stl_util.h"
 #include "base/threading/platform_thread.h"
+#include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"
 #include "chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h"
 #include "content/public/browser/browser_thread.h"
 #include "dbus/bus.h"
 #include "dbus/exported_object.h"
 #include "dbus/object_path.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
+namespace {
+
+CrosDBusService* g_cros_dbus_service = NULL;
+
+}  // namespace
+
 // The CrosDBusService implementation used in production, and unit tests.
 class CrosDBusServiceImpl : public CrosDBusService {
  public:
   explicit CrosDBusServiceImpl(dbus::Bus* bus)
       : service_started_(false),
         origin_thread_id_(base::PlatformThread::CurrentId()),
         bus_(bus) {
   }
 
   virtual ~CrosDBusServiceImpl() {
     STLDeleteElements(&service_providers_);
   }
 
-  // CrosDBusService override.
-  virtual void Start() {
+  // Starts the D-Bus service.
+  void Start() {
     // Make sure we're running on the origin thread (i.e. the UI thread in
     // production).
     DCHECK(OnOriginThread());
 
     // Return if the service has been already started.
     if (service_started_)
       return;
 
     bus_->RequestOwnership(kLibCrosServiceName,
                            base::Bind(&CrosDBusServiceImpl::OnOwnership,
@@ skipping 39 matching lines @@
 
 // The stub CrosDBusService implementation used on Linux desktop,
 // which does nothing as of now.
 class CrosDBusServiceStubImpl : public CrosDBusService {
  public:
   CrosDBusServiceStubImpl() {
   }
 
   virtual ~CrosDBusServiceStubImpl() {
   }
-
-  // CrosDBusService override.
-  virtual void Start() {
-  }
 };
 
 // static
-CrosDBusService* CrosDBusService::Create(dbus::Bus* bus) {
+void CrosDBusService::Initialize() {
+  if (g_cros_dbus_service) {
+    LOG(WARNING) << "CrosDBusService was already initialized";
+    return;
+  }
   if (base::chromeos::IsRunningOnChromeOS()) {
+    dbus::Bus* bus = DBusThreadManager::Get()->GetSystemBus();
     CrosDBusServiceImpl* service = new CrosDBusServiceImpl(bus);
     service->RegisterServiceProvider(ProxyResolutionServiceProvider::Create());
-    return service;
+    g_cros_dbus_service = service;
+    service->Start();
   } else {
-    return new CrosDBusServiceStubImpl;
+    g_cros_dbus_service = new CrosDBusServiceStubImpl;
   }
+  VLOG(1) << "CrosDBusService initialized";
 }
 
 // static
-CrosDBusService* CrosDBusService::CreateForTesting(
+void CrosDBusService::InitializeForTesting(
     dbus::Bus* bus,
     ServiceProviderInterface* proxy_resolution_service) {
+  if (g_cros_dbus_service) {
+    LOG(WARNING) << "CrosDBusService was already initialized";
+    return;
+  }
   CrosDBusServiceImpl* service =  new CrosDBusServiceImpl(bus);
   service->RegisterServiceProvider(proxy_resolution_service);
-  return service;
+  service->Start();
+  g_cros_dbus_service = service;
+  VLOG(1) << "CrosDBusService initialized";
+}
+
+// static
+void CrosDBusService::Shutdown() {
+  delete g_cros_dbus_service;
+  g_cros_dbus_service = NULL;
+  VLOG(1) << "CrosDBusService Shutdown completed";
 }
 
 CrosDBusService::~CrosDBusService() {
 }
 
 CrosDBusService::ServiceProviderInterface::~ServiceProviderInterface() {
 }
 
 }  // namespace chromeos