Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/browser/chromeos/dbus/cros_dbus_service.h

Issue 9839075: chromeos: Separate CrosDBusService Initialize/Shutdown from DBusThreadManager (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto ToT Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/dbus/cros_dbus_service.h
diff --git a/chrome/browser/chromeos/dbus/cros_dbus_service.h b/chrome/browser/chromeos/dbus/cros_dbus_service.h
index fdef812092709cd82f1219ef2d1249b74fd4af96..65e2f45d4995aaff354b25044a5f13bf3f2711d1 100644
--- a/chrome/browser/chromeos/dbus/cros_dbus_service.h
+++ b/chrome/browser/chromeos/dbus/cros_dbus_service.h
@@ -45,19 +45,19 @@ class CrosDBusService {
virtual ~ServiceProviderInterface();
};
- virtual ~CrosDBusService();
-
- // Starts the D-Bus service.
- virtual void Start() = 0;
+ // Initializes the global instance.
+ static void Initialize();
+ // Destroys the global instance.
+ static void Shutdown();
- // Creates the instance.
- static CrosDBusService* Create(dbus::Bus* bus);
+ protected:
+ virtual ~CrosDBusService();
private:
- // Creates the instance for testing. Takes the ownership of
+ // Initializes the global instance for testing. Takes the ownership of
// |proxy_resolution_service|.
friend class CrosDBusServiceTest;
- static CrosDBusService* CreateForTesting(
+ static void InitializeForTesting(
dbus::Bus* bus,
ServiceProviderInterface* proxy_resolution_service);
};
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chrome/browser/chromeos/dbus/cros_dbus_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698