[Sync] Display the client server traffic log in about:sync.

chrome/browser/sync/internal_api/sync_manager.cc

Index: chrome/browser/sync/internal_api/sync_manager.cc
diff --git a/chrome/browser/sync/internal_api/sync_manager.cc b/chrome/browser/sync/internal_api/sync_manager.cc
index a02c9658866dcaea1cb9d373df071eb8a2339230..87df4a297840a482dc1e6f6d3958920d4d7f7b21 100644
--- a/chrome/browser/sync/internal_api/sync_manager.cc
+++ b/chrome/browser/sync/internal_api/sync_manager.cc
@@ -170,6 +170,9 @@ class SyncManager::SyncInternal
     BindJsMessageHandler(
         "findNodesContainingString",
         &SyncManager::SyncInternal::FindNodesContainingString);
+    BindJsMessageHandler(
+        "getClientServerTraffic",
+        &SyncManager::SyncInternal::GetClientServerTraffic);
   }
 
   virtual ~SyncInternal() {
@@ -514,6 +517,7 @@ class SyncManager::SyncInternal
   JsArgList GetNodeDetailsById(const JsArgList& args);
   JsArgList GetChildNodeIds(const JsArgList& args);
   JsArgList FindNodesContainingString(const JsArgList& args);
+  JsArgList GetClientServerTraffic(const JsArgList& args);
 
   FilePath database_path_;
 
@@ -2182,6 +2186,21 @@ JsArgList SyncManager::SyncInternal::GetRootNodeDetails(
   return JsArgList(&return_args);
 }
 
+JsArgList SyncManager::SyncInternal::GetClientServerTraffic(
+    const JsArgList& args) {
+  ListValue return_args;
+  if (scheduler()) {
+    SyncSessionContext* context = scheduler()->session_context();

[tim (not reviewing), 2012/03/29 22:00:10]

It's circuitous and somewhat of a layering violation to request the session
context from the scheduler for use from SyncManager. SyncManager creates it and
blesses it with whatever state the lower engine layer needs from SyncManager
land. Unless I'm missing a unique circumstance here, it seems like there's no
reason to not follow the pattern all other objects use with SyncSessionContext
-- if the traffic recorder is meant to be used from SyncManager, then
SyncManager should create it and own it, and pass it into the context for the
lower layers to write to. 

And then we don't expose it from SyncScheduler.

[rlarocque, 2012/03/29 22:54:27]

+1

[lipalani1, 2012/03/29 23:58:37]

Done.

[lipalani1, 2012/03/29 23:58:37]

Done.

+    DictionaryValue* value = NULL;
+    if (context)
+      value = context->traffic_recorder()->ToValue();
+
+    if (value != NULL)
+      return_args.Append(value);
+  }
+  return JsArgList(&return_args);
+}
+
 namespace {
 
 int64 GetId(const ListValue& ids, int i) {