[Sync] Display the client server traffic log in about:sync.

chrome/browser/sync/internal_api/sync_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/internal_api/sync_manager.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 152 matching lines @@
         &SyncManager::SyncInternal::GetNodeSummariesById);
     BindJsMessageHandler(
         "getNodeDetailsById",
         &SyncManager::SyncInternal::GetNodeDetailsById);
     BindJsMessageHandler(
         "getChildNodeIds",
         &SyncManager::SyncInternal::GetChildNodeIds);
     BindJsMessageHandler(
         "findNodesContainingString",
         &SyncManager::SyncInternal::FindNodesContainingString);
+    BindJsMessageHandler(
+        "getClientServerTraffic",
+        &SyncManager::SyncInternal::GetClientServerTraffic);
   }
 
   virtual ~SyncInternal() {
     CHECK(!initialized_);
   }
 
   bool Init(const FilePath& database_location,
             const WeakHandle<JsEventHandler>& event_handler,
             const std::string& sync_server_and_path,
             int port,
@@ skipping 324 matching lines @@
       const NotificationInfoMap& notification_info);
 
   // JS message handlers.
   JsArgList GetNotificationState(const JsArgList& args);
   JsArgList GetNotificationInfo(const JsArgList& args);
   JsArgList GetRootNodeDetails(const JsArgList& args);
   JsArgList GetNodeSummariesById(const JsArgList& args);
   JsArgList GetNodeDetailsById(const JsArgList& args);
   JsArgList GetChildNodeIds(const JsArgList& args);
   JsArgList FindNodesContainingString(const JsArgList& args);
+  JsArgList GetClientServerTraffic(const JsArgList& args);
 
   FilePath database_path_;
 
   const std::string name_;
 
   base::ThreadChecker thread_checker_;
 
   base::WeakPtrFactory<SyncInternal> weak_ptr_factory_;
 
   // Thread-safe handle used by
@@ skipping 1648 matching lines @@
 JsArgList SyncManager::SyncInternal::GetRootNodeDetails(
     const JsArgList& args) {
   ReadTransaction trans(FROM_HERE, GetUserShare());
   ReadNode root(&trans);
   root.InitByRootLookup();
   ListValue return_args;
   return_args.Append(root.GetDetailsAsValue());
   return JsArgList(&return_args);
 }
 
+JsArgList SyncManager::SyncInternal::GetClientServerTraffic(
+    const JsArgList& args) {
+  ListValue return_args;
+  if (scheduler()) {
+    SyncSessionContext* context = scheduler()->session_context();

[tim (not reviewing), 2012/03/29 22:00:10]

It's circuitous and somewhat of a layering violation to request the session
context from the scheduler for use from SyncManager. SyncManager creates it and
blesses it with whatever state the lower engine layer needs from SyncManager
land. Unless I'm missing a unique circumstance here, it seems like there's no
reason to not follow the pattern all other objects use with SyncSessionContext
-- if the traffic recorder is meant to be used from SyncManager, then
SyncManager should create it and own it, and pass it into the context for the
lower layers to write to. 

And then we don't expose it from SyncScheduler.

[rlarocque, 2012/03/29 22:54:27]

+1

[lipalani1, 2012/03/29 23:58:37]

Done.

[lipalani1, 2012/03/29 23:58:37]

Done.

+    DictionaryValue* value = NULL;
+    if (context)
+      value = context->traffic_recorder()->ToValue();
+
+    if (value != NULL)
+      return_args.Append(value);
+  }
+  return JsArgList(&return_args);
+}
+
 namespace {
 
 int64 GetId(const ListValue& ids, int i) {
   std::string id_str;
   if (!ids.GetString(i, &id_str)) {
     return kInvalidId;
   }
   int64 id = kInvalidId;
   if (!base::StringToInt64(id_str, &id)) {
     return kInvalidId;
@@ skipping 323 matching lines @@
     share->directory->GetDownloadProgress(i.Get(), &marker);
 
     if (marker.token().empty())
       result.Put(i.Get());
 
   }
   return result;
 }
 
 }  // namespace sync_api