[Sync] Display the client server traffic log in about:sync.

chrome/browser/resources/sync_internals/traffic.js

Index: chrome/browser/resources/sync_internals/traffic.js
diff --git a/chrome/browser/resources/sync_internals/traffic.js b/chrome/browser/resources/sync_internals/traffic.js
new file mode 100755
index 0000000000000000000000000000000000000000..42a92a3b52971f11bcb769fef44374221869b4f9
--- /dev/null
+++ b/chrome/browser/resources/sync_internals/traffic.js
@@ -0,0 +1,22 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(function() {

[rlarocque, 2012/03/29 22:54:27]

I don't think this is good style, though I'm not sure what good style is. 
Should this be hooked up to an onLoad() event?  I guess it's better than the
current practice on about:sync of declaring global functions then directly
calling them. 

I'd feel better about this review if we included a JavaScript expert. 

[lipalani1, 2012/03/29 23:58:37]

ha ha I dont know either. I just copied from other places in about:sync that
does similar things.(like about.js etc. I will include Drew for review.)
On 2012/03/29 22:54:27, rlarocque wrote:

[akalin, 2012/03/30 01:55:04]

This is the 'Javascript way' of avoiding pollution of the global namespace. 
FWIW, the places this is copied from was reviewed by arv@ (Javascript guru) and
he let it stand.  I defer to Drew on this, though.

onLoad isn't necessary since this .js file is included after the elements it
references.

+var trafficToTextButton = document.getElementById('traffic-to-text');
+var trafficDump = document.getElementById('traffic-dump');
+trafficToTextButton.addEventListener('click', function(event) {
+  chrome.sync.getClientServerTraffic(printData);
+});
+
+function printData(trafficRecord) {
+  var traffic_data = '';
+  traffic_data += '===\n';
+  traffic_data += 'Client Server Traffic\n';
+  traffic_data += '===\n';
+  traffic_data += JSON.stringify(trafficRecord, null, 2);
+  traffic_data += '\n';
+
+  trafficDump.textContent = traffic_data;
+}
+})();