Issue 9826028: Rename AudioRendererBase and AudioRendererAlgorithmBase

Issue 9826028: Rename AudioRendererBase and AudioRendererAlgorithmBase (Closed)

Created:
8 years, 9 months ago by vrk (LEFT CHROMIUM)

Modified:
8 years, 8 months ago

Reviewers:
jam, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename AudioRendererBase and AudioRendererAlgorithmBase Neither of these classes are base classes anymore, so rename to AudioRendererImpl and AudioRendererAlgorithm respectively BUG=116645 TEST=media_unittests; chrome compiles and runs audio/video Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131481

Patch Set 1 #

Patch Set 2 : Rebase ToT #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : Rebase ToT #

Patch Set 7 : Fix player compiler errors #

Patch Set 8 : Unit tests were somehow unadded #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -2210 lines)			Patch
M	content/renderer/media/audio_device.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	media/audio/null_audio_sink.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A +	media/filters/audio_renderer_algorithm.h	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download
A +	media/filters/audio_renderer_algorithm.cc	View	1	15 chunks	+26 lines, -26 lines	0 comments	Download
D	media/filters/audio_renderer_algorithm_base.h	View	1	1 chunk	+0 lines, -203 lines	0 comments	Download
D	media/filters/audio_renderer_algorithm_base.cc	View	1	1 chunk	+0 lines, -444 lines	0 comments	Download
D	media/filters/audio_renderer_algorithm_base_unittest.cc	View		1 chunk	+0 lines, -287 lines	0 comments	Download
A +	media/filters/audio_renderer_algorithm_unittest.cc	View	1 2 3 4 5 6 7	9 chunks	+21 lines, -21 lines	0 comments	Download
D	media/filters/audio_renderer_base.h	View	1 2 3	1 chunk	+0 lines, -211 lines	0 comments	Download
D	media/filters/audio_renderer_base.cc	View	1 2 3	1 chunk	+0 lines, -483 lines	0 comments	Download
D	media/filters/audio_renderer_base_unittest.cc	View		1 chunk	+0 lines, -442 lines	0 comments	Download
A +	media/filters/audio_renderer_impl.h	View	1 2 3	5 chunks	+13 lines, -13 lines	0 comments	Download
A +	media/filters/audio_renderer_impl.cc	View	1 2 3	18 chunks	+29 lines, -29 lines	0 comments	Download
A +	media/filters/audio_renderer_impl_unittest.cc	View	1 2 3 4 5 6 7	16 chunks	+23 lines, -23 lines	0 comments	Download
M	media/filters/pipeline_integration_test_base.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/media.gyp	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	media/tools/player_wtl/movie.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/tools/player_x11/player_x11.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vrk (LEFT CHROMIUM)

jam: content OWNERS scherkus: everything else! This CL is based off of: https://chromiumcodereview.appspot.com/9826023/

8 years, 9 months ago (2012-03-22 21:30:50 UTC) #1

jam

On 2012/03/22 21:30:50, Victoria Kirst wrote: > jam: content OWNERS lgtm

8 years, 9 months ago (2012-03-22 21:54:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/9826028/11001

8 years, 8 months ago (2012-04-09 17:27:12 UTC) #4

commit-bot: I haz the power

Try job failure for 9826028-11001 (retry) on android for steps "Compile, build". It's a second ...

8 years, 8 months ago (2012-04-09 17:41:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/9826028/22003

8 years, 8 months ago (2012-04-09 22:06:47 UTC) #6

Change committed as 131481

Expand Messages | Collapse Messages