Created a new class SpdyTestStateHelper to serve as a helper to manage the state of a number of SPD…

Created a new class SpdyTestStateHelper to serve as a helper to manage the state of a number of SPDY global variables.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128163

[Ryan Hamilton, 2012-03-21 19:52:41]

willchan: as we discussed, here is CL which centralizes the frobbing of SPDY
global variables in the constructors/destructors of a class which can then be
included as a private member of our text fixtures.

[willchan no longer on Chromium, 2012-03-22 01:21:04]

LGTM

https://chromiumcodereview.appspot.com/9817014/diff/1/net/spdy/spdy_test_util...
File net/spdy/spdy_test_util_spdy2.cc (right):

https://chromiumcodereview.appspot.com/9817014/diff/1/net/spdy/spdy_test_util...
net/spdy/spdy_test_util_spdy2.cc:1010:
SpdyTestStateHelper::SpdyTestStateHelper() {
I dunno, it would feel cleaner to me if there were an accessor so you can store
the original value of the global variable and then restore it at the end, rather
than just forcibly writing a constant value in the destructor.

[Ryan Hamilton, 2012-03-22 02:38:35]

https://chromiumcodereview.appspot.com/9817014/diff/1/net/spdy/spdy_test_util...
File net/spdy/spdy_test_util_spdy2.cc (right):

https://chromiumcodereview.appspot.com/9817014/diff/1/net/spdy/spdy_test_util...
net/spdy/spdy_test_util_spdy2.cc:1010:
SpdyTestStateHelper::SpdyTestStateHelper() {
On 2012/03/22 01:21:04, willchan wrote:
> I dunno, it would feel cleaner to me if there were an accessor so you can
store
> the original value of the global variable and then restore it at the end,
rather
> than just forcibly writing a constant value in the destructor.

Added a TODO.  I wonder if a ResetStatics() method (like we have in SpdySession)
might be cleaner.  That helps prevent the damage a poorly written test can do.

[commit-bot: I haz the power, 2012-03-22 02:39:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9817014/1029

[commit-bot: I haz the power, 2012-03-22 03:40:40]

Change committed as 128163