Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: net/spdy/buffered_spdy_framer_spdy2_unittest.cc

Issue 9817014: Created a new class SpdyTestStateHelper to serve as a helper to manage the state of a number of SPD… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/buffered_spdy_framer_spdy2_unittest.cc
diff --git a/net/spdy/buffered_spdy_framer_spdy2_unittest.cc b/net/spdy/buffered_spdy_framer_spdy2_unittest.cc
index b001fba5fb5af4c8c14f78a88b6503d7c2952bc3..f627da2b3720a77c47df1bd962eb3102703b6fca 100644
--- a/net/spdy/buffered_spdy_framer_spdy2_unittest.cc
+++ b/net/spdy/buffered_spdy_framer_spdy2_unittest.cc
@@ -143,10 +143,6 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
class BufferedSpdyFramerSpdy2Test : public PlatformTest {
protected:
- void EnableCompression(bool enabled) {
- SpdyFramer::set_enable_compression_default(enabled);
- }
-
// Returns true if the two header blocks have equivalent content.
bool CompareHeaderBlocks(const SpdyHeaderBlock* expected,
const SpdyHeaderBlock* actual) {
@@ -173,11 +169,12 @@ class BufferedSpdyFramerSpdy2Test : public PlatformTest {
}
return true;
}
+
+ private:
+ SpdyTestStateHelper spdy_state_;
};
TEST_F(BufferedSpdyFramerSpdy2Test, OnSetting) {
- EnableCompression(false);
-
SpdyFramer framer(2);
SpdySettings settings;
settings.push_back(SpdySetting(SettingsFlagsAndId(0, 1), 0x00000002));
@@ -194,8 +191,6 @@ TEST_F(BufferedSpdyFramerSpdy2Test, OnSetting) {
}
TEST_F(BufferedSpdyFramerSpdy2Test, ReadSynStreamHeaderBlock) {
- EnableCompression(false);
-
SpdyHeaderBlock headers;
headers["aa"] = "vv";
headers["bb"] = "ww";
@@ -221,8 +216,6 @@ TEST_F(BufferedSpdyFramerSpdy2Test, ReadSynStreamHeaderBlock) {
}
TEST_F(BufferedSpdyFramerSpdy2Test, ReadSynReplyHeaderBlock) {
- EnableCompression(false);
-
SpdyHeaderBlock headers;
headers["alpha"] = "beta";
headers["gamma"] = "delta";
@@ -246,8 +239,6 @@ TEST_F(BufferedSpdyFramerSpdy2Test, ReadSynReplyHeaderBlock) {
}
TEST_F(BufferedSpdyFramerSpdy2Test, ReadHeadersHeaderBlock) {
- EnableCompression(false);
-
SpdyHeaderBlock headers;
headers["alpha"] = "beta";
headers["gamma"] = "delta";
« no previous file with comments | « net/http/http_proxy_client_socket_pool_spdy3_unittest.cc ('k') | net/spdy/buffered_spdy_framer_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698