Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: net/spdy/spdy_http_stream_spdy3_unittest.cc

Issue 9817014: Created a new class SpdyTestStateHelper to serve as a helper to manage the state of a number of SPD… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_stream_spdy2_unittest.cc ('k') | net/spdy/spdy_network_transaction_spdy21_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_stream_spdy3_unittest.cc
diff --git a/net/spdy/spdy_http_stream_spdy3_unittest.cc b/net/spdy/spdy_http_stream_spdy3_unittest.cc
index 68a958ce6ce4dd4b953488196b667ecd0e9e26b4..a42050d9f48aac1dcfcfb7cc575c2d50981e9d24 100644
--- a/net/spdy/spdy_http_stream_spdy3_unittest.cc
+++ b/net/spdy/spdy_http_stream_spdy3_unittest.cc
@@ -25,10 +25,6 @@ class SpdyHttpStreamSpdy3Test : public testing::Test {
protected:
SpdyHttpStreamSpdy3Test() {}
- void EnableCompression(bool enabled) {
- spdy::SpdyFramer::set_enable_compression_default(enabled);
- }
-
virtual void SetUp() {
SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY3);
}
@@ -74,11 +70,12 @@ class SpdyHttpStreamSpdy3Test : public testing::Test {
scoped_refptr<HttpNetworkSession> http_session_;
scoped_refptr<SpdySession> session_;
scoped_refptr<TransportSocketParams> transport_params_;
+
+ private:
+ SpdyTestStateHelper spdy_state_;
};
TEST_F(SpdyHttpStreamSpdy3Test, SendRequest) {
- EnableCompression(false);
-
scoped_ptr<spdy::SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST));
MockWrite writes[] = {
CreateMockWrite(*req.get(), 1),
@@ -125,7 +122,6 @@ TEST_F(SpdyHttpStreamSpdy3Test, SendRequest) {
}
TEST_F(SpdyHttpStreamSpdy3Test, SendChunkedPost) {
- EnableCompression(false);
UploadDataStream::set_merge_chunks(false);
scoped_ptr<spdy::SpdyFrame> req(ConstructChunkedSpdyPost(NULL, 0));
@@ -188,8 +184,6 @@ TEST_F(SpdyHttpStreamSpdy3Test, SendChunkedPost) {
// Test case for bug: http://code.google.com/p/chromium/issues/detail?id=50058
TEST_F(SpdyHttpStreamSpdy3Test, SpdyURLTest) {
- EnableCompression(false);
-
const char * const full_url = "http://www.google.com/foo?query=what#anchor";
const char * const base_url = "http://www.google.com/foo?query=what";
scoped_ptr<spdy::SpdyFrame> req(ConstructSpdyGet(base_url, false, 1, LOWEST));
@@ -297,8 +291,6 @@ void SpdyHttpStreamSpdy3Test::TestSendCredentials(
const std::string& cert,
const std::string& proof,
SSLClientCertType type) {
- EnableCompression(false);
-
spdy::SpdyCredential cred;
cred.slot = 1;
cred.proof = proof;
« no previous file with comments | « net/spdy/spdy_http_stream_spdy2_unittest.cc ('k') | net/spdy/spdy_network_transaction_spdy21_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698