Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 9805005: [Web Intents] Fix crash when invoking intent in incognito mode. (Closed)

Created:
8 years, 9 months ago by binji
Modified:
8 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Visibility:
Public.

Description

[Web Intents] Fix crash when invoking intent in incognito mode. BUG=117497 TEST=WebIntentPickerControllerIncognitoBrowserTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128153

Patch Set 1 #

Total comments: 8

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M chrome/browser/ui/intents/web_intent_picker_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 3 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
8 years, 9 months ago (2012-03-21 23:56:22 UTC) #1
groby-ooo-7-16
http://codereview.chromium.org/9805005/diff/1/chrome/browser/ui/intents/web_intent_picker_controller.cc File chrome/browser/ui/intents/web_intent_picker_controller.cc (right): http://codereview.chromium.org/9805005/diff/1/chrome/browser/ui/intents/web_intent_picker_controller.cc#newcode128 chrome/browser/ui/intents/web_intent_picker_controller.cc:128: if (wrapper_->profile()->IsOffTheRecord()) We probably need to do more than ...
8 years, 9 months ago (2012-03-22 00:20:24 UTC) #2
binji
http://codereview.chromium.org/9805005/diff/1/chrome/browser/ui/intents/web_intent_picker_controller.cc File chrome/browser/ui/intents/web_intent_picker_controller.cc (right): http://codereview.chromium.org/9805005/diff/1/chrome/browser/ui/intents/web_intent_picker_controller.cc#newcode128 chrome/browser/ui/intents/web_intent_picker_controller.cc:128: if (wrapper_->profile()->IsOffTheRecord()) On 2012/03/22 00:20:24, groby wrote: > We ...
8 years, 9 months ago (2012-03-22 00:38:40 UTC) #3
groby-ooo-7-16
lgtm
8 years, 9 months ago (2012-03-22 00:45:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9805005/6001
8 years, 9 months ago (2012-03-22 02:10:21 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 03:16:55 UTC) #6
Change committed as 128153

Powered by Google App Engine
This is Rietveld 408576698