[Web Intents] Fix crash when invoking intent in incognito mode.

chrome/browser/ui/intents/web_intent_picker_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 105 matching lines @@
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 void WebIntentPickerController::ShowDialog(Browser* browser,
                                            const string16& action,
                                            const string16& type) {
   // Only show a picker once.
   if (picker_shown_)
     return;
 
+  // TODO(binji): Remove this check when we decide how to allow intent
+  // invocation in incognito mode.
+  if (wrapper_->profile()->IsOffTheRecord())

[groby-ooo-7-16, 2012/03/22 00:20:24]

We probably need to do more than just remove that check - that'd get us back to
crashing state, no? 

// TODO(binji): Clarify what to do when intents are invoked from incognito mode

instead?

[binji, 2012/03/22 00:38:40]

Done.

+    return;
+
   picker_model_->Clear();
 
   // If picker is non-NULL, it was set by a test.
   if (picker_ == NULL) {
     picker_ = WebIntentPicker::Create(browser, wrapper_, this,
                                       picker_model_.get());
   }
 
   picker_shown_ = true;
   pending_async_count_+= 2;
@@ skipping 285 matching lines @@
   if (--pending_async_count_ == 0) {
     picker_->OnPendingAsyncCompleted();
   }
 }
 
 void WebIntentPickerController::ClosePicker() {
   if (picker_) {
     picker_->Close();
   }
 }