[Web Intents] Fix crash when invoking intent in incognito mode.

chrome/browser/ui/intents/web_intent_picker_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 56 matching lines @@
   // WebIntentPickerDelegate implementation.
   virtual void OnServiceChosen(const GURL& url,
                                Disposition disposition) OVERRIDE;
   virtual void OnInlineDispositionWebContentsCreated(
       content::WebContents* web_contents) OVERRIDE;
   virtual void OnCancelled() OVERRIDE;
   virtual void OnClosing() OVERRIDE;
 
  private:
   friend class WebIntentPickerControllerTest;
+  friend class WebIntentPickerControllerBrowserIncognitoTest;

[groby-ooo-7-16, 2012/03/22 00:20:24]

FRIEND_TEST_ALL_PREFIXES(WebIntentPickerControllerIncognitoBrowserTest,
ShowDialogShouldntCrash)

I know, we have other friend statements for tests in here that don't do that
either... Mind hitting them too? ;)

[binji, 2012/03/22 00:38:40]

The individual tests don't need to be friends, just the test class. This seems
to be common:
http://code.google.com/p/chromium/source/search?q=friend%5C+class%5C+.*Test&o...

   friend class WebIntentPickerControllerBrowserTest;
   friend class InvokingTabObserver;
 
   // Gets a notification when the return message is sent to the source tab,
   // so we can close the picker dialog or service tab.
   void OnSendReturnMessage(webkit_glue::WebIntentReplyType reply_type);
 
   // Exposed for tests only.
   void set_picker(WebIntentPicker* picker) { picker_ = picker; }
 
@@ skipping 79 matching lines @@
 
   // Request consumer used when asynchronously loading favicons.
   CancelableRequestConsumerTSimple<size_t> favicon_consumer_;
 
   base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController);
 };
 
 #endif  // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_