Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 973001: Version 2.1.4.1... (Closed)

Created:
10 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Version 2.1.4.1 Reverting fast double to string conversion algorithm which triggers bug in gcc ARM cross-compiler. Reverting Committed: http://code.google.com/p/v8/source/detail?r=4135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4203 lines) Patch
M src/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
D src/cached_powers.h View 1 chunk +0 lines, -119 lines 0 comments Download
M src/checks.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/conversions.cc View 3 chunks +3 lines, -13 lines 0 comments Download
D src/diy_fp.h View 1 chunk +0 lines, -136 lines 0 comments Download
D src/double.h View 1 chunk +0 lines, -169 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -5 lines 0 comments Download
D src/grisu3.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/grisu3.cc View 1 chunk +0 lines, -494 lines 0 comments Download
D src/powers_ten.h View 1 chunk +0 lines, -2461 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/SConscript View 2 chunks +0 lines, -4 lines 0 comments Download
D test/cctest/gay_shortest.h View 1 chunk +0 lines, -44 lines 0 comments Download
D test/cctest/test-diy_fp.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D test/cctest/test-double.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D test/cctest/test-grisu3.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D tools/generate-ten-powers.scm View 1 chunk +0 lines, -286 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 9 months ago (2010-03-15 15:29:51 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-15 15:30:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698