Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9701086: Adjust signatures to pass string rather than char* since it ultimately constructs a GURL. (Closed)

Created:
8 years, 9 months ago by Sheridan Rawlins
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, Danh Nguyen, tfarina
Visibility:
Public.

Description

Adjust signatures to pass string rather than char* since it ultimately constructs a GURL. R=jhawkins@chromium.org BUG=None TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTest*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127785

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address tfarina's nits. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M chrome/browser/ui/webui/bidi_checker_web_ui_test.h View 1 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 4 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sheridan Rawlins
8 years, 9 months ago (2012-03-16 00:32:15 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-18 03:04:50 UTC) #2
tfarina
http://codereview.chromium.org/9701086/diff/1/chrome/browser/ui/webui/bidi_checker_web_ui_test.h File chrome/browser/ui/webui/bidi_checker_web_ui_test.h (right): http://codereview.chromium.org/9701086/diff/1/chrome/browser/ui/webui/bidi_checker_web_ui_test.h#newcode25 chrome/browser/ui/webui/bidi_checker_web_ui_test.h:25: void RunBidiCheckerOnPage(const std::string& pageURL, bool isRTL); nit: page_url, is_rtl ...
8 years, 9 months ago (2012-03-19 00:59:27 UTC) #3
Sheridan Rawlins
http://codereview.chromium.org/9701086/diff/1/chrome/browser/ui/webui/bidi_checker_web_ui_test.h File chrome/browser/ui/webui/bidi_checker_web_ui_test.h (right): http://codereview.chromium.org/9701086/diff/1/chrome/browser/ui/webui/bidi_checker_web_ui_test.h#newcode25 chrome/browser/ui/webui/bidi_checker_web_ui_test.h:25: void RunBidiCheckerOnPage(const std::string& pageURL, bool isRTL); On 2012/03/19 00:59:27, ...
8 years, 9 months ago (2012-03-20 18:51:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/9701086/12001
8 years, 9 months ago (2012-03-20 18:52:28 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 21:16:24 UTC) #6 
Change committed as 127785

Powered by Google App Engine
This is Rietveld 408576698