Adjust signatures to pass string rather than char* since it ultimately constructs a GURL.

chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
 
 #include "base/base_paths.h"
 #include "base/i18n/rtl.h"
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 33 matching lines @@
 WebUIBidiCheckerBrowserTest::~WebUIBidiCheckerBrowserTest() {}
 
 WebUIBidiCheckerBrowserTest::WebUIBidiCheckerBrowserTest() {}
 
 void WebUIBidiCheckerBrowserTest::SetUpInProcessBrowserTestFixture() {
   WebUIBrowserTest::SetUpInProcessBrowserTestFixture();
   WebUIBrowserTest::AddLibrary(WebUIBidiCheckerLibraryJSPath());
   WebUIBrowserTest::AddLibrary(FilePath(kBidiCheckerTestsJS));
 }
 
-void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(const char pageURL[],
-                                                       bool isRTL) {
-  ui_test_utils::NavigateToURL(browser(), GURL(pageURL));
+void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(
+    const std::string& page_url, bool is_rtl) {
+  ui_test_utils::NavigateToURL(browser(), GURL(page_url));
   ASSERT_TRUE(RunJavascriptTest("runBidiChecker",
-                                Value::CreateStringValue(pageURL),
-                                Value::CreateBooleanValue(isRTL)));
+                                Value::CreateStringValue(page_url),
+                                Value::CreateBooleanValue(is_rtl)));
 }
 
 void WebUIBidiCheckerBrowserTestLTR::RunBidiCheckerOnPage(
-    const char pageURL[]) {
-  WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(pageURL, false);
+    const std::string& page_url) {
+  WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(page_url, false);
 }
 
 void WebUIBidiCheckerBrowserTestRTL::RunBidiCheckerOnPage(
-    const char pageURL[]) {
-  WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(pageURL, true);
+    const std::string& page_url) {
+  WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(page_url, true);
 }
 
 void WebUIBidiCheckerBrowserTestRTL::SetUpOnMainThread() {
   WebUIBidiCheckerBrowserTest::SetUpOnMainThread();
   FilePath pak_path;
   app_locale_ = base::i18n::GetConfiguredLocale();
   ASSERT_TRUE(PathService::Get(base::FILE_MODULE, &pak_path));
   pak_path = pak_path.DirName();
   pak_path = pak_path.AppendASCII("pseudo_locales");
   pak_path = pak_path.AppendASCII("fake-bidi");
@@ skipping 210 matching lines @@
                                 "\x99\xD7\x9F\x20\x32\x33",
                                 "\xD7\xA7\xD7\x95\xD7\x9E\xD7\x94\x20\x32\x36",
                                 "\xD7\xAA\xD7\x9C\x20\xD7\x90\xD7\x91\xD7\x99"
                                 "\xD7\x91",
                                 "",
                                 "66183",
                                 "\xD7\x99\xD7\xA9\xD7\xA8\xD7\x90\xD7\x9C",
                                 "0000");
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kAutofillSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 // http://crbug.com/94642
 // http://crbug.com/95425
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        DISABLED_TestSettingsAutofillPage) {
   SetupSettingsAutofillPageTest(browser()->profile(),
                                 "Milton",
                                 "C.",
                                 "Waddams",
                                 "red.swingline@initech.com",
                                 "Initech",
                                 "4120 Freidrich Lane",
                                 "Basement",
                                 "Austin",
                                 "Texas",
                                 "78744",
                                 "United States",
                                 "5125551234");
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kAutofillSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
                        TestSettingsClearBrowserDataPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kClearBrowserDataSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        MAYBE_TestSettingsClearBrowserDataPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kClearBrowserDataSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
                        TestSettingsContentSettingsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kContentSettingsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        MAYBE_TestSettingsContentSettingsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kContentSettingsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
                        TestSettingsContentSettingsExceptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kContentSettingsExceptionsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        MAYBE_TestSettingsContentSettingsExceptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kContentSettingsExceptionsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
                        TestSettingsLanguageOptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kLanguageOptionsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 // http://crbug.com/117871
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        DISABLED_TestSettingsLanguageOptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kLanguageOptionsSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
                        TestSettingsSearchEnginesOptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kSearchEnginesSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        MAYBE_TestSettingsSearchEnginesOptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kSearchEnginesSubPage);
-  RunBidiCheckerOnPage(url.c_str());
+  RunBidiCheckerOnPage(url);
 }