Added bidi tests for uber iframes.

Added bidi tests for remaining uber iframes.

This CL continues James's work in http://codereview.chromium.org/9664050/

Please review the changes.  Thanks.

Danh

BUG=112060
TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTest*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128216

[Danh Nguyen, 2012-03-15 21:43:02]

Please review the changes.

Thanks,
Danh

[James Hawkins, 2012-03-15 22:01:33]

http://codereview.chromium.org/9700065/diff/1002/chrome/browser/ui/webui/bidi...
File chrome/browser/ui/webui/bidi_checker_web_ui_test.cc (right):

http://codereview.chromium.org/9700065/diff/1002/chrome/browser/ui/webui/bidi...
chrome/browser/ui/webui/bidi_checker_web_ui_test.cc:229: #define
MAYBE_TestSettingsFrameSyncSetup \
I'd like to get the CrOS failure fixed before adding these tests. Danh do you
think you can work on that?

[Danh Nguyen, 2012-03-16 14:13:46]

http://codereview.chromium.org/9700065/diff/1002/chrome/browser/ui/webui/bidi...
File chrome/browser/ui/webui/bidi_checker_web_ui_test.cc (right):

http://codereview.chromium.org/9700065/diff/1002/chrome/browser/ui/webui/bidi...
chrome/browser/ui/webui/bidi_checker_web_ui_test.cc:229: #define
MAYBE_TestSettingsFrameSyncSetup \
On 2012/03/15 22:01:33, James Hawkins wrote:
> I'd like to get the CrOS failure fixed before adding these tests. Danh do you
> think you can work on that?
I'd love to work on fixing this bug.  I'm going to work on that.  Thanks James.

[Sheridan Rawlins, 2012-03-16 20:15:50]

FYI, http://codereview.chromium.org/9701086/ modifies similar code (to change
char[] to string&).

[Danh Nguyen, 2012-03-21 20:01:26]

Hi All,

I've fixed the bug 117923 (as James recommended), so now we can add many more
bidi tests which work for both Chrome & ChromeOS.

I've also merged the changes Sheridan has made in the same file.

Could you take another look at this CL?

Chris, I'm going to need your owner blessing to check this in.  So please take a
look whenever you have a chance.

Thanks,
Danh

[csilv, 2012-03-21 21:53:14]

lgtm

[Danh Nguyen, 2012-03-22 13:35:22]

On 2012/03/21 21:53:14, csilv wrote:
> lgtm

Thanks Chris.

Danh

[commit-bot: I haz the power, 2012-03-22 13:35:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danhn@chromium.org/9700065/8001

[commit-bot: I haz the power, 2012-03-22 15:48:33]

Change committed as 128216