Added bidi tests for uber iframes.

chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
 
 #include "base/base_paths.h"
 #include "base/i18n/rtl.h"
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 190 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestPluginsPage) {
   RunBidiCheckerOnPage(chrome::kChromeUIPluginsURL);
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestPluginsPage) {
   RunBidiCheckerOnPage(chrome::kChromeUIPluginsURL);
 }
 
 //==============================
-// chrome://settings
+// chrome://settings-frame
 //==============================
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestSettingsPage) {
   RunBidiCheckerOnPage(chrome::kChromeUISettingsFrameURL);
 }
 
 // http://crbug.com/117923
 #if defined(OS_CHROMEOS)
 #define MAYBE_TestSettingsPage DISABLED_TestSettingsPage
 #define MAYBE_TestSettingsClearBrowserDataPage \
     DISABLED_TestSettingsClearBrowserDataPage
 #define MAYBE_TestSettingsContentSettingsPage \
     DISABLED_TestSettingsContentSettingsPage
 #define MAYBE_TestSettingsContentSettingsExceptionsPage \
     DISABLED_TestSettingsContentSettingsExceptionsPage
 #define MAYBE_TestSettingsSearchEnginesOptionsPage \
     DISABLED_TestSettingsSearchEnginesOptionsPage
+#define MAYBE_TestSettingsFrameSyncSetup \

[James Hawkins, 2012/03/15 22:01:33]

I'd like to get the CrOS failure fixed before adding these tests. Danh do you
think you can work on that?

[Danh Nguyen, 2012/03/16 14:13:46]

I'd love to work on fixing this bug.  I'm going to work on that.  Thanks James.

+    DISABLED_TestSettingsFrameSyncSetup
+#define MAYBE_TestSettingsFrameStartup \
+    DISABLED_TestSettingsFrameStartup
+#define MAYBE_TestSettingsFrameImportData \
+    DISABLED_TestSettingsFrameImportData
+#define MAYBE_TestSettingsFrameMangageProfile \
+    DISABLED_TestSettingsFrameMangageProfile
+#define MAYBE_TestSettingsFrameContentExceptionsCookies \
+    DISABLED_TestSettingsFrameContentExceptionsCookies
+#define MAYBE_TestSettingsFrameContentExceptionsImages \
+    DISABLED_TestSettingsFrameContentExceptionsImages
+#define MAYBE_TestSettingsFrameContentExceptionsJavascript \
+    DISABLED_TestSettingsFrameContentExceptionsJavascript
+#define MAYBE_TestSettingsFrameContentExceptionsPlugins \
+    DISABLED_TestSettingsFrameContentExceptionsPlugins
+#define MAYBE_TestSettingsFrameContentExceptionsPopups \
+    DISABLED_TestSettingsFrameContentExceptionsPopups
+#define MAYBE_TestSettingsFrameContentExceptionsLocation \
+    DISABLED_TestSettingsFrameContentExceptionsLocation
+#define MAYBE_TestSettingsFrameContentExceptionsNotifications \
+    DISABLED_TestSettingsFrameContentExceptionsNotifications
+#define MAYBE_TestSettingsFrameContentExceptionsMouseLock \
+    DISABLED_TestSettingsFrameContentExceptionsMouseLock
+#define MAYBE_TestSettingsFrameHandler \
+    DISABLED_TestSettingsFrameHandler
+#define MAYBE_TestSettingsFrameCookies \
+    DISABLED_TestSettingsFrameCookies
+#define MAYBE_TestSettingsFramePasswords \
+    DISABLED_TestSettingsFramePasswords
 #else
 #define MAYBE_TestSettingsPage TestSettingsPage
 #define MAYBE_TestSettingsClearBrowserDataPage TestSettingsClearBrowserDataPage
 #define MAYBE_TestSettingsContentSettingsPage TestSettingsContentSettingsPage
 #define MAYBE_TestSettingsContentSettingsExceptionsPage \
     TestSettingsContentSettingsExceptionsPage
 #define MAYBE_TestSettingsSearchEnginesOptionsPage \
     TestSettingsSearchEnginesOptionsPage
+#define MAYBE_TestSettingsFrameSyncSetup \
+    TestSettingsFrameSyncSetup
+#define MAYBE_TestSettingsFrameStartup \
+    TestSettingsFrameStartup
+#define MAYBE_TestSettingsFrameImportData \
+    TestSettingsFrameImportData
+#define MAYBE_TestSettingsFrameMangageProfile \
+    TestSettingsFrameMangageProfile
+#define MAYBE_TestSettingsFrameContentExceptionsCookies \
+    TestSettingsFrameContentExceptionsCookies
+#define MAYBE_TestSettingsFrameContentExceptionsImages \
+    TestSettingsFrameContentExceptionsImages
+#define MAYBE_TestSettingsFrameContentExceptionsJavascript \
+    TestSettingsFrameContentExceptionsJavascript
+#define MAYBE_TestSettingsFrameContentExceptionsPlugins \
+    TestSettingsFrameContentExceptionsPlugins
+#define MAYBE_TestSettingsFrameContentExceptionsPopups \
+    TestSettingsFrameContentExceptionsPopups
+#define MAYBE_TestSettingsFrameContentExceptionsLocation \
+    TestSettingsFrameContentExceptionsLocation
+#define MAYBE_TestSettingsFrameContentExceptionsNotifications \
+    TestSettingsFrameContentExceptionsNotifications
+#define MAYBE_TestSettingsFrameContentExceptionsMouseLock \
+    TestSettingsFrameContentExceptionsMouseLock
+#define MAYBE_TestSettingsFrameHandler \
+    TestSettingsFrameHandler
+#define MAYBE_TestSettingsFrameCookies \
+    TestSettingsFrameCookies
+#define MAYBE_TestSettingsFramePasswords \
+    TestSettingsFramePasswords
 #endif  // defined(OS_CHROMEOS)
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, MAYBE_TestSettingsPage) {
   RunBidiCheckerOnPage(chrome::kChromeUISettingsFrameURL);
 }
 
 static void SetupSettingsAutofillPageTest(Profile* profile,
                                           const char* first_name,
                                           const char* middle_name,
                                           const char* last_name,
@@ skipping 138 matching lines @@
   url += std::string(chrome::kSearchEnginesSubPage);
   RunBidiCheckerOnPage(url.c_str());
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
                        MAYBE_TestSettingsSearchEnginesOptionsPage) {
   std::string url(chrome::kChromeUISettingsFrameURL);
   url += std::string(chrome::kSearchEnginesSubPage);
   RunBidiCheckerOnPage(url.c_str());
 }
+
+//===================================
+// chrome://settings-frame/syncSetup
+//===================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameSyncSetup) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += std::string(chrome::kSyncSetupSubPage);
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameSyncSetup) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += std::string(chrome::kSyncSetupSubPage);
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================
+// chrome://settings-frame/startup
+//===================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameStartup) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "startup";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameStartup) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "startup";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================
+// chrome://settings-frame/importData
+//===================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameImportData) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kImportDataSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameImportData) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kImportDataSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//========================================
+// chrome://settings-frame/manageProfile
+//========================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameMangageProfile) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kManageProfileSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameMangageProfile) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kManageProfileSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#cookies
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsCookies) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#cookies";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsCookies) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#cookies";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#images
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsImages) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#images";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsImages) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#images";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//======================================================
+// chrome://settings-frame/contentExceptions#javascript
+//======================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsJavascript) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#javascript";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsJavascript) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#javascript";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#plugins
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsPlugins) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#plugins";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsPlugins) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#plugins";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#popups
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsPopups) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#popups";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsPopups) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#popups";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#location
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsLocation) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#location";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsLocation) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#location";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#notifications
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsNotifications) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#notifications";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsNotifications) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#notifications";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//===================================================
+// chrome://settings-frame/contentExceptions#mouselock
+//===================================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameContentExceptionsMouseLock) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#mouselock";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameContentExceptionsMouseLock) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kContentSettingsExceptionsSubPage;
+  url += "#mouselock";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//========================================
+// chrome://settings-frame/handlers
+//========================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameHandler) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kHandlerSettingsSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameHandler) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += chrome::kHandlerSettingsSubPage;
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//========================================
+// chrome://settings-frame/cookies
+//========================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameCookies) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "cookies";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFrameCookies) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "cookies";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//========================================
+// chrome://settings-frame/passwords
+//========================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFramePasswords) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "passwords";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       MAYBE_TestSettingsFramePasswords) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "passwords";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+//========================================
+// chrome://settings-frame/fonts
+//========================================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
+                       TestSettingsFrameFonts) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "fonts";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+// http://crbug.com/118420
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
+                       DISABLED_TestSettingsFrameFonts) {
+  std::string url(chrome::kChromeUISettingsFrameURL);
+  url += "fonts";
+  RunBidiCheckerOnPage(url.c_str());
+}
+
+// Test other uber iframes.
+
+//==============================
+// chrome://extensions-frame
+//==============================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestExtensionsFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIExtensionsFrameURL);
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestExtensionsFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIExtensionsFrameURL);
+}
+
+//==============================
+// chrome://help-frame
+//==============================
+
+// http://crbug.com/118477
+#if defined(OS_CHROMEOS)
+#define MAYBE_TestHelpFrame DISABLED_TestHelpFrame
+#else
+#define MAYBE_TestHelpFrame TestHelpFrame
+#endif  // defined(OS_CHROMEOS)
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHelpFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIHelpFrameURL);
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, MAYBE_TestHelpFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIHelpFrameURL);
+}
+
+//==============================
+// chrome://history-frame
+//==============================
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHistoryFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
+}
+
+IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestHistoryFrame) {
+  RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
+}